<br><br><div class="gmail_quote">On Mon, Feb 6, 2012 at 5:05 PM, Kris Zygmunt <span dir="ltr"><<a href="mailto:krismz@sci.utah.edu">krismz@sci.utah.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
On Feb 2, 2012, at 12:28 PM, Xiaoxiao Liu wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Kris,<br>
Thanks for the details.<br>
I think it makes sense to have the GPU modules in different groups according to their functionality. The only thing I am concerned is that we lose the convenience of having a Group switch for GPU modules. But I guess we can use ITK_USE_GPU to do something similar.<br>
<br>
What I did earlier with 5 video modules is that I checked in the least dependent module(VideoCore) for review first and gradually checked the rest of modules in bundles according to the module dependencies. I wouldn't trying to put all modules to review at once. If you check in a giant patch, it might take longer to review than the patch by patch way. Anyway, just my two cents.<br>
<br>
</blockquote>
<br></div>
I have created the first patch for the GPUCommon module and submitted it to gerrit with topic name GPUCommon <a href="http://review.source.kitware.com/#/c/4190/" target="_blank">http://review.source.kitware.<u></u>com/#/c/4190/</a> . Other than some changes to cmake files and itkMacro.h to help with building the GPU code, this patch consists of first moving the files in Modules/GPU/Common to Modules/Core/GPUCommon and then modifying some of those files. The annoying thing is that git seems to have interpreted these two actions to mean delete the Modules/GPU/Common files and create new files in Modules/Core/GPUCommon even though I used git mv for the first step. Thus the diffs provided are unhelpful. Is there any way I can do these steps in a single commit and have git track the diffs accordingly?<div class="im">
<br></div></blockquote><div><br></div><div>>> "git mv" usually works for me. Sometimes when I forgot to do "git mv" at first. I usually end up doing "git add" for the rename files and then "git mv" to remove the old git file paths. And then git will still recognize the renaming without a problem.</div>
<div><br></div><div>Did you make changes (including formatting) first to those files before doing "git mv"?</div><div><br></div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I could help you to set up a couple of dashboard testing machines. At least you could submit experimental builds from your machine to make sure reviewers could verify the patches.<br>
<br>
-Xiaoxiao<br>
<br>
</blockquote>
<br></div>
What do I need to do to submit the experimental builds? Who should I recruit to help review this GPU code? So far, I think Jim Miller, Luis Ibanez and Xiaoxiao are on that list, who else?</blockquote><div> </div><div>>> You could add reviewers from the following list:</div>
<div> <a href="http://www.itk.org/Wiki/index.php?title=ITK/Gerrit/Reviewers&oldid=41166#Explicit_List">http://www.itk.org/Wiki/index.php?title=ITK/Gerrit/Reviewers&oldid=41166#Explicit_List</a></div><div><br></div>
<div> </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
-Kris<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div><br></div>---------------------------------------------<br><b>Xiaoxiao Liu</b>, Ph.D.<div><div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">R & D Engineer</span></font></div>
<div><div><a href="http://www.kitware.com/" target="_blank">Kitware Inc</a>.</div></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px">Clifton Park, NY</span><div><div>Phone: (518) 881-4924 or <span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">(518) 371-3971 x124</span></div>
<div><font face="Verdana, Arial, Helvetica, sans-serif"><span style="line-height:31px;font-size:x-small"><br></span></font></div></div></div></div></div><br>