<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Brad,<div><br></div><div>I checked today to see if the patch was successful in removing </div><div>the valgrind errors but from the line numbers mentioned in the</div><div>errors, it would seem that perhaps the valgrind machine hasn't </div><div>updated since before I pushed the patch on Monday. I thought </div><div>the builds get updated code every night. Is this not necessarily</div><div>the case?</div><div><br></div><div>Thanks,</div><div>Nick</div><div><br></div><div><br><div><div>On Mar 26, 2012, at 10:50 AM, Nicholas Tustison wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">My guess is that this patch will probably fix the current<div>three valgrind errors.<br><div><br></div><div><a href="http://review.source.kitware.com/#/c/4833/">http://review.source.kitware.com/#/c/4833/</a></div><div><br></div><div>Basically I initialized the size of the metric derivative</div><div>outside the call of the metric.</div><div><br></div><div>Nick<br><div><br></div><div><br><div><div>On Mar 26, 2012, at 10:17 AM, Nicholas Tustison wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Michael and Brian,<div><br></div><div>If you take a look at the valgrind error that Brad linked</div><div>to, it's basically the same as the two other registration</div><div>method valgrind errors where we perform optimization </div><div>within the method class itself because they have to be </div><div>handled individually. What's interesting is that the only </div><div>other similar class where we don't get a valgrind error is</div><div>the itkTimeVaryingBSplineVelocityFieldImageRegistrationMethod</div><div>class but I just looked and there was a bug in which we</div><div>were calling the metric GetValueAndDerivative() function</div><div>twice. I fixed that here</div><div><br></div><div><a href="http://review.source.kitware.com/#/c/4823/">http://review.source.kitware.com/#/c/4823/</a></div><div><br></div><div>but I bet you that by fixing it we'll add another valgrind </div><div>error. </div><div><br></div><div>What I can't figure out is why. For standard registration</div><div>in which we're using the base class, </div><div>ImageToImageRegistrationMethod, the optimizer calls</div><div>the GetValueAndDerivative() function and there's no</div><div>valgrind error. What I'm wondering if is if the valgrind </div><div>checking sees the repeated resizing of the metric </div><div>derivative as a problem.</div><div><br></div><div>Nick</div><div><br></div><div><br></div><div><br><div><div>On Mar 26, 2012, at 9:20 AM, Bradley Lowekamp wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hello,</div><div><br></div><div>I was just closely looking at the dashboard, and noticed that the valgrind number of defect increased to 3. This one looks like the new one.</div><div><br></div><a href="http://open.cdash.org/viewDynamicAnalysisFile.php?id=2726550">http://open.cdash.org/viewDynamicAnalysisFile.php?id=2726550</a><div><br></div><div><br></div><div>If there other two defects are not going to be addressed and they are considered false positives, they really should be suppressed, so that new defects can more easily be seen.</div><div><br></div><div>Brad</div><div><br><div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; font-size: 12px; "><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">========================================================</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Bradley Lowekamp<span class="Apple-converted-space"> </span><span class="Apple-converted-space"> </span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Medical Science and Computing for</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Office of High Performance Computing and Communications</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">National Library of Medicine<span class="Apple-converted-space"> </span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-size: 12px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; "><a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a></font></div><span class="Apple-style-span" style="font-size: 12px; "><br class="Apple-interchange-newline"></span></div><br class="Apple-interchange-newline">
</div>
<br></div></div>_______________________________________________<br>Powered by <a href="http://www.kitware.com/">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br><br>Kitware offers ITK Training Courses, for more information visit:<br><a href="http://kitware.com/products/protraining.php">http://kitware.com/products/protraining.php</a><br><br>Please keep messages on-topic and check the ITK FAQ at:<br><a href="http://www.itk.org/Wiki/ITK_FAQ">http://www.itk.org/Wiki/ITK_FAQ</a><br><br>Follow this link to subscribe/unsubscribe:<br>http://www.itk.org/mailman/listinfo/insight-developers<br></blockquote></div><br></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></body></html>