<br><br><div class="gmail_quote">On Tue, May 29, 2012 at 8:24 PM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:brad@lowekamp.net" target="_blank">brad@lowekamp.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
This also happens when one topic adds a file, and the other topics up for review don't have said new file.</div></blockquote><div><br></div><div>That makes sense.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"> I hope you don't expect that to end any time soon:)<br></div></blockquote><div><br></div><div>Certainly not! :-) </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
<br>
So this is a problem that needs a solution.<br></div></blockquote><div><br></div><div>Bill L. came up with an idea that will always detect when the header tests need to be regenerated correctly without killing performance. Simply do a basic diff of the content and only write the .cxx file if things have changed.</div>
<div><br></div><div>Matt</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
</div>Brad<br>
<div class="im HOEnZb"><br>
On May 29, 2012, at 3:55 PM, Matt McCormick wrote:<br>
<br>
</div><div class="HOEnZb"><div class="h5">> If moving or renaming file names, a fresh build is required. Or a<br>
> manual run of<br>
><br>
> make ITKHeaderTests<br>
><br>
> will regenerate all the tests. The CDash@Home machines are configured<br>
> to do incremental builds for performance reasons, but they are reset<br>
> every night. The errors will disappear the next day.<br>
><br>
> This will not be a problem if we do not rename classes, which we will<br>
> need to stop very soon...<br>
><br>
> Matt<br>
><br>
> On Tue, May 29, 2012 at 3:38 PM, M Stauffer -V- <<a href="mailto:mstauff@verizon.net">mstauff@verizon.net</a>> wrote:<br>
>> Yeah, this has been happening with the header tests on lots of different<br>
>> systems and patches. I don't think it's anything particular to my patches,<br>
>> unless I'm wrong<br>
>> ?The header tests build info isn't being properly refreshed, it seems. I<br>
>> don't know any more that that, though.<br>
>><br>
>> -M<br>
>><br>
>> ________________________________<br>
>> From: Bradley Lowekamp [mailto:<a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a>]<br>
>> Sent: Tuesday, May 29, 2012 3:07 PM<br>
>> To: Williams, Norman K<br>
>> Cc: Michael Stauffer; ITK<br>
>><br>
>> Subject: Re: [Insight-developers] Dashboard needs attention<br>
>><br>
>> I got that too on my local build. I deleted the HeaderTest's cxx file and<br>
>> it was fine afterwards.<br>
>><br>
>><br>
>> On May 29, 2012, at 3:02 PM, Williams, Norman K wrote:<br>
>><br>
>> Still kinda garfed up.<br>
>><br>
>> /scratch/kent/itktest/ITK-build/Modules/Numerics/Optimizersv4/test/ITKOptim<br>
>> izersv4HeaderTest1.cxx:38:10: fatal error:<br>
>> 'itkRegistrationParameterScalesFromShift.hxx' file not found<br>
>> #include "itkRegistrationParameterScalesFromShift.hxx"<br>
>> ^<br>
>> 1 error generated.<br>
>> make[2]: ***<br>
>> [Modules/Numerics/Optimizersv4/CMakeFiles/ITKOptimizersv4HeaderTest1.dir/te<br>
>> s<br>
>><br>
>><br>
>> --<br>
>> Kent Williams <a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> On 5/29/12 11:10 AM, "Michael Stauffer" <<a href="mailto:mgstauffcircularfwd@gmail.com">mgstauffcircularfwd@gmail.com</a>><br>
>> wrote:<br>
>><br>
>> Sorry guys. I should have rebased onto master before merging. I'll<br>
>><br>
>> look at the issues now.<br>
>><br>
>><br>
>> -M<br>
>><br>
>><br>
>><br>
>><br>
>> ________________________________________<br>
>><br>
>> From: Bradley Lowekamp<br>
>><br>
>> [mailto:<a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a>]<br>
>><br>
>> Sent: Tuesday, May 29, 2012 9:17<br>
>><br>
>> AM<br>
>><br>
>> To: Bill Lorensen<br>
>><br>
>> Cc: Insight Developers; Michael<br>
>><br>
>> Stauffer (Circular Logic); brian avants<br>
>><br>
>> Subject: Re:<br>
>><br>
>> [Insight-developers] Dashboard needs attention<br>
>><br>
>><br>
>><br>
>> Bill,<br>
>><br>
>><br>
>> I just wanted to point out that Michaels topic was compiling just fine<br>
>><br>
>> from the branch point, however the compilation errors on the dashboard<br>
>><br>
>> is due<br>
>><br>
>> to a compilation of Michaels and Brian's changes. Both work<br>
>><br>
>> independently but<br>
>><br>
>> together they have a logical conflict with each other.<br>
>><br>
>><br>
>> Brad<br>
>><br>
>><br>
>><br>
>> On May 29, 2012, at 8:36 AM, Bill Lorensen wrote:<br>
>><br>
>><br>
>><br>
>> Michael,<br>
>><br>
>><br>
>> You recent checkins are not<br>
>><br>
>> compiling.<br>
>><br>
>><br>
>> Bill<br>
>><br>
>> _______________________________________________<br>
>><br>
>> Powered<br>
>><br>
>> by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a>><br>
>><br>
>><br>
>> Visit other<br>
>><br>
>> Kitware open-source projects at<br>
>><br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>><br>
>> Kitware<br>
>><br>
>> offers ITK Training Courses, for more information<br>
>><br>
>> visit:<br>
>><br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>><br>
>> Please keep<br>
>><br>
>> messages on-topic and check the ITK FAQ<br>
>><br>
>> at:<br>
>><br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>><br>
>> Follow this link to<br>
>><br>
>> subscribe/unsubscribe:<br>
>><br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> ========================================================<br>
>><br>
>> Bradley Lowekamp<br>
>><br>
>> Medical Science and Computing for<br>
>><br>
>> Office of High Performance Computing and<br>
>><br>
>> Communications<br>
>><br>
>> National Library of Medicine<br>
>><br>
>> <a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>><br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>><br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>><br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>><br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>><br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>><br>
>><br>
>><br>
>><br>
>> ________________________________<br>
>> Notice: This UI Health Care e-mail (including attachments) is covered by the<br>
>> Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential<br>
>> and may be legally privileged. If you are not the intended recipient, you<br>
>> are hereby notified that any retention, dissemination, distribution, or<br>
>> copying of this communication is strictly prohibited. Please reply to the<br>
>> sender that you have received the message in error, then delete it. Thank<br>
>> you.<br>
>> ________________________________<br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>><br>
>><br>
>> ========================================================<br>
>><br>
>> Bradley Lowekamp<br>
>><br>
>> Medical Science and Computing for<br>
>><br>
>> Office of High Performance Computing and Communications<br>
>><br>
>> National Library of Medicine<br>
>><br>
>> <a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>><br>
<br>
</div></div></blockquote></div><br>