<div>Hi Kent, </div><div><br></div>Additionally, with or without "<span style>ITK_USE_SYSTEM_DCMTK", let's make sure we can pass the location of DCMTK using DCMTK_DIR.</span><div><font color="#222222" face="arial, sans-serif"><br>
</font></div><div><font color="#222222" face="arial, sans-serif">Thanks</font></div><div><font color="#222222" face="arial, sans-serif">Jc<br></font><br><div class="gmail_quote">On Tue, May 29, 2012 at 11:28 AM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you treat dcmtk as we treat vtk then you will not need a<br>
ITK_USE_SYSTEM_DCMTK.<br>
<br>
On Tue, May 29, 2012 at 10:03 AM, Williams, Norman K<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a>> wrote:<br>
> Whatever we end up doing in ITK, there will be a ITK_USE_SYSTEM_DCMTK<br>
> option.<br>
><br>
><br>
> And yes, recent versions of DCMTK work with CLang. I logged the problems I<br>
> ran into in the DCMTK bug tracker.<br>
><br>
> The DCMTK people are close to a new minor version release, which will<br>
> incorporate all these changes; I believe it's coming in the next few<br>
> weeks. That might be a good revision to standardize on going forward.<br>
><br>
> On 5/25/12 5:00 PM, "Jean-Christophe Fillion-Robin"<br>
> <<a href="mailto:jchris.fillionr@kitware.com">jchris.fillionr@kitware.com</a>> wrote:<br>
><br>
>>Hi Kent,<br>
> >From Slicer perspective, independently of the method used to retrieve<br>
>>DCMTK (git submodule or ExternalProject), if would be great if we could<br>
>>configure ITKv4 passing our own version of DCMTK by specifying DCMTK_DIR.<br>
>><br>
>>Within CTK, since end of April, a more recent version of DCMTK is used<br>
>>(Snapshot 2012-02-22). See [1] And looking at the associated DCMTK change<br>
>>log, some CLang issues have been fixed. [2]<br>
>><br>
>><br>
>>Thanks<br>
>>Jc<br>
>><br>
>>[1] <a href="https://github.com/commontk/CTK/commit/70c0a8d" target="_blank">https://github.com/commontk/CTK/commit/70c0a8d</a><br>
>>[2]<br>
>><a href="http://git.dcmtk.org/web?p=dcmtk.git;a=blob;f=CHANGES.361;h=d281e817cbd647" target="_blank">http://git.dcmtk.org/web?p=dcmtk.git;a=blob;f=CHANGES.361;h=d281e817cbd647</a><br>
>>479dacb5e972f2d76d75602c25;hb=ae3b946f6e6231<br>
>><br>
>>On Fri, May 25, 2012 at 5:47 PM, Williams, Norman K<br>
>><<a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a>> wrote:<br>
>><br>
>>Hans has asked me to work on finishing Alexandre Gouaillard's work on the<br>
>>DCMTK ImageIO.<br>
>><br>
>>Today I've been trying to move his work from his own github repository<br>
>>into a gerrit topic on the current branch. There are a number of issues<br>
>>that this raises.<br>
>><br>
>>1. Hans suggested using a CMake ExternalProject to build DCMTK instead of<br>
>>what Alex did, which is to introduce the DCMTK included in the CTK project<br>
>>as a git module. For one thing, that version of DCMTK won't compile with<br>
>>Clang.<br>
>><br>
>>I don't see a clean way to grab and build DCMTK within the current ITK<br>
>>framework at all. What's done everywhere else is that there's a<br>
>>SuperBuild or MetaBuild, which builds all of a project's prerequisites as<br>
>>ExternalProjects, and then builds the project itself as an<br>
>>ExternalProject, configuring it with ITK_DIR, VTK_DIR etc so that it finds<br>
>>the prerequisites.<br>
>><br>
>>Could that be something that will be part of the ITK build process? Or are<br>
>>we going to incorporate some sort of snapshot of DCMTK in<br>
>>Modules/ThirdParty?<br>
>><br>
>>2. DCMTK can read a DICOM directory directly, meaning that it wouldn't be<br>
>>necessary to use an ImageSeriesReader to read dicom datasets. Should I<br>
>>stick with creating a DCMTKSeriesFileNames?<br>
>><br>
>>That feels rather clumsy, but it raises the issue of trying to choose<br>
>>which image in a multi-series DicomDirectory to load.<br>
>><br>
>>--<br>
>>Kent Williams <a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>>________________________________<br>
>>Notice: This UI Health Care e-mail (including attachments) is covered by<br>
>>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is<br>
>>confidential and may be legally privileged. If you are not the intended<br>
>>recipient, you are hereby notified that any retention, dissemination,<br>
>>distribution, or copying of this communication is strictly prohibited.<br>
>>Please reply to the sender that you have received the message in error,<br>
>>then delete it. Thank you.<br>
>><br>
>><br>
>>________________________________<br>
>>_______________________________________________<br>
>>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a>><br>
>><br>
>>Visit other Kitware open-source projects at<br>
>><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>>Kitware offers ITK Training Courses, for more information visit:<br>
>><a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>>Please keep messages on-topic and check the ITK FAQ at:<br>
>><a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>>Follow this link to subscribe/unsubscribe:<br>
>><a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>>--<br>
>><a href="tel:%2B1%20919%20869%208849" value="+19198698849">+1 919 869 8849</a><br>
>><br>
>><br>
>><br>
>>_______________________________________________<br>
>>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>>Visit other Kitware open-source projects at<br>
>><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>>Kitware offers ITK Training Courses, for more information visit:<br>
>><a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>>Please keep messages on-topic and check the ITK FAQ at:<br>
>><a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>>Follow this link to subscribe/unsubscribe:<br>
>><a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
><br>
><br>
><br>
> ________________________________<br>
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
> ________________________________<br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>
<br>
<br>
</div></div><div class="HOEnZb"><div class="h5">--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>+1 919 869 8849<br><br>
</div>