Hi Kent, <div>Please seem my comments below. Thanks!<br><br><div class="gmail_quote">On Thu, May 31, 2012 at 1:07 PM, Williams, Norman K <span dir="ltr"><<a href="mailto:norman-k-williams@uiowa.edu" target="_blank">norman-k-williams@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I've switched up how DCMTK gets built and deployed based on valuable<br>
feedback from Brad King & Bradley Lowencamp, who hereafter shall be<br>
referred to as The Two Brads, or just T2B.<br>
<br>
As a proof of concept -- or until someone tells me it's just a horrible<br>
idea -- instead of hacking the DCMTK build stuff into the top-level ITK<br>
directory, I'm trying out a different solution: I'm adding<br>
ITK/Modules/ThirdParty/DCMTK, and putting all the ExternalProject stuff in<br>
there.<br>
<br>
Why am I doing this?<br>
<br>
1. If I hypnotise CMake into thinking there's an ITK Module there, then I<br>
can have ITKIODCMTK depend on ITKDCMTK.<br>
2. It cleans up the top level CMakeLists.txt and doesn't stink up ITK/CMake<br>
<br></blockquote><div>>> I think it's a good idea to be consistent with other third party libraries in ITK.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The questions I have right now:<br>
<br>
1. If I move all the external project implementation into<br>
ITK/Modules/ThirdParty/DCMTK, I don't know how to make the Module (I.e.<br>
the ITKDCMTK Module) depend on running the ExternalProject build for<br>
DCMTK. Which is to say, if the ExternalProject macro call is there in<br>
ITK/Modules/ThirdParty/DCMTK/CMakeList, DCMTK will get built eventually,<br>
but I'm not sure that the chain of dependency is there such that it will<br>
get built before the ITKIODCMTK module.<br></blockquote><div><br></div><div>>> I don't think there will be a problem. As long as the correct dependencies are specified in ITKIODCMTK (namely, it depends on ITKDCMTK), its depending modules will be built before itself.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
2. how would I get the list of DCMTK libraries to be installed once DCMTK<br>
is built? Right now, the include directories, library list, and the lib<br>
directory get suck into the proper lists, but in the case of actually<br>
installing ITK, none of them would get added to the installation.<br></blockquote><div><br></div><div>>> In itkExternal_DCMTK.cmake, you could add some install rules so that it could get installed right after building? Just my two cents. </div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
3. Is this even a good idea?<br>
<br></blockquote><div>>>I think so. </div><div><div> In ITKBridgeOpenCV and ITKBridgeVXL modules, they rely on system installed OpenCV and VXL libraires. We didn't put in any super build mechanism for them yet. But if you claim a big sucess with this one, </div>
<div>I think it would be an example to follow.</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
________________________________<br>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
________________________________<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div><br></div>---------------------------------------------<br><b>Xiaoxiao Liu</b>, Ph.D.<div><div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">R & D Engineer</span></font></div>
<div><div><a href="http://www.kitware.com/" target="_blank">Kitware Inc</a>.</div></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px">Clifton Park, NY</span><div><div>Phone: (518) 881-4924 or <span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">(518) 371-3971 x124</span></div>
<div><font face="Verdana, Arial, Helvetica, sans-serif"><span style="line-height:31px;font-size:x-small"><br></span></font></div></div></div></div></div><br>
</div>