Is there any reason for us to be using vnl_math?<br><br><div class="gmail_quote">On Wed, Oct 31, 2012 at 5:02 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, 31 Oct 2012 20:47:57 +0000, Matt McCormick said:<br>
<br>
>Hi,<br>
><br>
>Recently, changes were made in vnl_math.h so that vnl_math_abs is now<br>
>vnl_math::abs, etc.<br>
><br>
>This is causing pain in ITK :-(.<br>
><br>
>What is the recommended way to deal with this change in a<br>
>backwards-compatible way? I could not find pre-processor version<br>
>definitions in core/vnl/vnl_config.h or core/vxl_config.h<br>
<br>
</div>This is partly my fault... and is ironic because the change was meant to *help* ITK. :(<br>
<br>
I submitted a patch to the vxl folks based on this:<br>
<<a href="http://review.source.kitware.com/#/c/6025/" target="_blank">http://review.source.kitware.com/#/c/6025/</a>><br>
<br>
see the thread "Patch from ITK (Avoid C++0x constexpr error)" on the vxl list. After some discussion about whether to accept the patch or not, it was accepted (but expanded on!) and committed in r35854 (and perhaps others).<br>
<br>
I'm not sure why Peter made even more extensive changes... Peter?<br>
<br>
Cheers,<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Unpaid intern in BillsBasement at noware dot com<br><br>