I agree that they should follow a consistent style, but an attempt at backwards compatibility should be made. Those variables are hard set in many people's ExternalProject's, build scripts, etc.<br><br>Matt<br><br>
<div class="gmail_quote">On Tue, Dec 18, 2012 at 4:25 PM, Williams, Norman K <span dir="ltr"><<a href="mailto:norman-k-williams@uiowa.edu" target="_blank">norman-k-williams@uiowa.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think you're exactly right. Those variables are named the way they are<br>
because when I chose those names USE_<something> names were all over the<br>
place. As we've all progressed as developers and refined the conventions<br>
used in ITK, things like that have gone away.<br>
<br>
<br>
I see no reason not to change this to make it consistent. As far as<br>
'backwards compatibility' -- we promise code compatibility not CMake<br>
compatibility. Since FFTW is not on by default, someone has to go looking<br>
when they run CMake for the FFTW variables to turn on. They'll find them<br>
whether they're properly prefixed ITK_ or not.<br>
<br>
And that little snippet of CMake code is something I never thought about.<br>
CMake programming sure can be powerful. At this point we could probably<br>
re-write ITK in CMake.<br>
<div><div class="h5"><br>
On 12/18/12 9:38 AM, "Bradley Lowekamp" <<a href="mailto:blowekamp@mail.nih.gov">blowekamp@mail.nih.gov</a>> wrote:<br>
<br>
>Hello,<br>
><br>
>I was looking to pass some CMake variable from my SimpleITK superbuild<br>
>down to the ITK external project build. So I assembled a list for cmake<br>
>varaibles that began with "ITK_":<br>
><br>
>get_cmake_property( _varNames VARIABLES )<br>
><br>
>foreach (_varName ${_varNames})<br>
> if(_varName MATCHES "^ITK_" )<br>
> message( "Variable defined ${_varName}: ${${_varName}}")<br>
> list(APPEND ITK_VARS ${_varName})<br>
> endif()<br>
>endforeach()<br>
><br>
><br>
>And passed to those to my ITK external project. While these ITK cmake<br>
>variables are not defined in the top level, a user could base say<br>
>"-DITK_USE_SYSTEM_TIFF:BOOL=ON" to the top level superbuild, and ITK<br>
>would be configured and build with this user specified option. (This will<br>
>get a lot more interesting when enabling module could also be passes.)<br>
><br>
>Only problem is that the FFTW cmake variables don't match. These are the<br>
>ones I am talking about:<br>
><br>
>USE_SYSTEM_FFTW<br>
>USE_FFTWD<br>
>USE_FFTWF<br>
><br>
>I think that these variable should begin with ITK to match the reset of<br>
>the similar variable in ITK.<br>
><br>
>Does anyone else have an opinion on this?<br>
><br>
><br>
>Thanks,<br>
>Brad<br>
><br>
>_______________________________________________<br>
>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
>Visit other Kitware open-source projects at<br>
><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
>Kitware offers ITK Training Courses, for more information visit:<br>
><a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
><br>
>Please keep messages on-topic and check the ITK FAQ at:<br>
><a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
>Follow this link to subscribe/unsubscribe:<br>
><a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>
<br>
<br>
</div></div>________________________________<br>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
________________________________<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br>