Yes, will definitely put in the EXCLUDE_FROM_ALL tag there.<div>Thanks.<br><br><div class="gmail_quote">On Tue, Jan 15, 2013 at 2:41 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Xiaxiao,<br>
<br>
I think it makes sense to keep External for local module testing.<br>
Perhaps we need to update the documentation.<br>
<br>
Also, as I mentioned, I would suggest that we recommend<br>
EXCLUDE_FROM_ALL for external module writers. Otherwise, once it's<br>
fetched, you can't turn off a remote module unless you delete the<br>
source code directory.<br>
<br>
Nice snowman,<br>
<br>
Bill<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Jan 15, 2013 at 1:31 PM, Xiaoxiao Liu <<a href="mailto:xiaoxiao.liu@kitware.com">xiaoxiao.liu@kitware.com</a>> wrote:<br>
> Hi Bill,<br>
> +1 on your experience and suggestions.<br>
><br>
> Remote module is indeed a convenient and quick way to bring in new<br>
> contributions into ITK! Thanks to Matt!<br>
><br>
> It would be great to introduce a remote module template into the Insight<br>
> Journal Submission process, so that each IJ code submission is wrapped<br>
> into an ITK module and can be fetched during the CMake configuration time<br>
> when building ITK. We have documented how to construct an ITK module in<br>
> the tutorial<br>
> (<a href="http://insightsoftwareconsortium.github.com/ITKBarCamp-doc/ITK/ConstructITKModule/index.html" target="_blank">http://insightsoftwareconsortium.github.com/ITKBarCamp-doc/ITK/ConstructITKModule/index.html</a>)<br>
> , we just need to add this additional remote CMake file to enable the fetch.<br>
> I am planning to work on this, will keep you posted in terms of progress.<br>
><br>
> Just want to clarify a little bit about different between the remote<br>
> modules and external modules: We used to call modules distributed<br>
> separately from the ITK repo as "External" modules. Now we are supporting<br>
> the "fetch" feature, we use "Remote" modules to emphasis the new feature.<br>
><br>
> "Modules/External" is therefore merely a place holder for local module<br>
> testing. If this causes confusion ( I assume it does) with the remote<br>
> modules, there is no reason to keep it.<br>
><br>
><br>
><br>
><br>
> On Wed, Jan 2, 2013 at 4:40 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Folks,<br>
>><br>
>> I am working on two remote modules for ITK. Here is a summary of my<br>
>> experience:<br>
>><br>
>> 1) It is a great way to integrate external contributions.<br>
>> 2) The process is simple.<br>
>><br>
>> Process suggestions:<br>
>> 1) Remote modules should set EXCLUDE_FROM_ALL in the itk_module.<br>
>> Without this, there is no way to disable the remote module, once it is<br>
>> fetched.<br>
>> 2) We might consider removing Modules/External. I don't see much of an<br>
>> advantage to having it.<br>
>> 3) We should advertise it more. It only requires adding one file to<br>
>> Modules/Remote to integrate small and large contributions.<br>
>><br>
>> I was able to add an Insight Journal article (with one class) and the<br>
>> ITK Wiki Examples (with almost 300 examples) as Remote modules with<br>
>> very little effort.<br>
>><br>
>> Bill<br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
><br>
><br>
><br>
><br>
> --<br>
><br>
><br>
> ---------------------------------------------<br>
> Xiaoxiao Liu, Ph.D.<br>
> R & D Engineer<br>
> Kitware Inc.<br>
> Clifton Park, NY<br>
> Phone: <a href="tel:%28518%29%20881-4924" value="+15188814924">(518) 881-4924</a> or <a href="tel:%28518%29%20371-3971%20x124" value="+15183713971">(518) 371-3971 x124</a><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div><br></div>---------------------------------------------<br><b>Xiaoxiao Liu</b>, Ph.D.<div><div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">R & D Engineer</span></font></div>
<div><div><a href="http://www.kitware.com/" target="_blank">Kitware Inc</a>.</div></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px">Clifton Park, NY</span><div><div>Phone: (518) 881-4924 or <span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">(518) 371-3971 x124</span></div>
<div><font face="Verdana, Arial, Helvetica, sans-serif"><span style="line-height:31px;font-size:x-small"><br></span></font></div></div></div></div></div>
</div>