<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I agree with everyone :)<div><br></div><div>This style is a huge pain. But it does make things look a little better.</div><div><br></div><div>What about a compromise? Perhaps we can enforce it in the header but not the implementation files. I think that could easily be done with KWStyle rules.</div><div><br></div><div>Brad</div><div><br><div><div>On Feb 1, 2013, at 12:36 PM, "Johnson, Hans J" <<a href="mailto:hans-johnson@uiowa.edu">hans-johnson@uiowa.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<div style="word-wrap: break-word; font-size: 14px; font-family: Calibri, sans-serif; ">
<div>
<div>
<div>Hello ITK community,</div>
<div><br>
</div>
<div>I'd like to take a poll about your feelings regarding an ITK style decision that has been in place for a very long time.</div>
<div><br>
</div>
<div>The ITK style guide states that all typedefs that are on adjacent lines MUST be justified the same. While I think that this is often a good practice, this rule also obfuscates the code sometimes, and it makes unnecessary changes in code that is unrelated
to the line of code in question (for example, if an internal type name is renamed to better represent the code, the 10 typedefs around that one also need to change).</div>
<div><br>
</div>
<div>
<div style="font-family:Consolas; font-size:medium">As a side note, the "Clean Code" book advices against such alignement as it emphasizes a relationship between the elements in a column. It should instead emphasize the relationship between the elements in
a row (when you look at those lines, it's usually to know what is the type of the variable -> horizontal relationship).</div>
<div style="font-family:Consolas; font-size:medium">This also has 2 practical limitations:</div>
<div style="font-family:Consolas; font-size:medium">- when the variable type or name are long too long that it reach the number of characters per line.</div>
<div style="font-family:Consolas; font-size:medium">- adding a new type with a name longer than the existing forces all the other rows to be changed, which adds noise into the history.</div>
</div>
<div><br>
</div>
<div>NOTE: Making this change in style policy will NOT require any code to be changed. It does allow more flexibility in the future.</div>
<div><br>
</div>
<div>============================</div>
<div>Please respond to this message so that a historical record of this proposals pro's/con's can be recorded on the mailing list.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Hans</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>
<div>
<div style="font-family:Consolas; font-size:medium">
<div style="font-family:Consolas,monospace; font-size:12px">=================================================================</div>
<div style="font-family:Consolas,monospace; font-size:12px">Hans J. Johnson, Ph.D.</div>
<div style="font-family:Consolas,monospace; font-size:12px">Assistant Professor, Department of Psychiatry</div>
<div style="font-family:Consolas,monospace; font-size:12px"><br>
</div>
<div style="font-family:Consolas,monospace; font-size:12px">Mailing Address:</div>
<div style="font-family:Consolas,monospace; font-size:12px">W274 GH Email: <a href="mailto:hans-johnson@uiowa.edu">hans-johnson@uiowa.edu</a></div>
<div style="font-family:Consolas,monospace; font-size:12px">200 Hawkins Drive Phone: (319) 353 8587</div>
<div style="font-family:Consolas,monospace; font-size:12px">The University of Iowa</div>
<div style="font-family:Consolas,monospace; font-size:12px">Iowa City, IA 52242</div>
</div>
</div>
</div>
</div>
</div>
<br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div>
_______________________________________________<br>Powered by <a href="http://www.kitware.com">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br><br>Kitware offers ITK Training Courses, for more information visit:<br>http://kitware.com/products/protraining.php<br><br>Please keep messages on-topic and check the ITK FAQ at:<br>http://www.itk.org/Wiki/ITK_FAQ<br><br>Follow this link to subscribe/unsubscribe:<br>http://www.itk.org/mailman/listinfo/insight-developers<br></blockquote></div><br></div></body></html>