<div dir="ltr">Thanks Brad for looking at the issue so quickly :)<div><br></div><div style>I reviewed your patch in gerrit and posted comment.</div><div style><br></div><div style>Thanks</div><div style>Jc</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Apr 3, 2013 at 11:33 AM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hello JC,<div><br></div><div>This is quite an interesting side-effect of the changes I introduced.</div><div><br></div><div>I am glad that you were able to figure this out. For a variety of reasons, it's likely a very bad thing for all that to occur during static initialization in ITK. So it certainly needs to be fixed.</div>
<div><br></div><div>I agree that lazy initialization is the way to go. Unfortunately it needs to be thread safe so its a little more completed.</div><div><br></div><div>ITKv4 performs the factory initialization when the user creates the first ITK object. And that changed with this patch, and need to be fixed.</div>
<div><br></div><div>CONCLUSION:</div><div><br></div><div>Inside ITK, we can not use statically initialized ITK object.</div><div><br></div><div>Brad</div><div><br><div><div><div class="h5"><div>On Apr 3, 2013, at 10:54 AM, Jean-Christophe Fillion-Robin <<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>> wrote:</div>
<br></div></div><blockquote type="cite"><div><div class="h5"><div dir="ltr">Hi Brad, <div><br></div><div>Following commit 4c47e7d [1] of February 19th and commit defb9c1 [2] of March 1st, due to static initialization, the initialization of ObjectFactory now happens when ITK shared library are loaded [3][4].</div>
<div><br></div><div>This caused a regression in Slicer where the ObjectFactory were expected to be loaded while attempting to load an image for the first time. </div><div><br></div><div>In Slicer case, the environment variable ITK_AUTOLOAD_PATH was set during the initialization of the qSlicerCoreApplication, which is now too late.</div>
<div><br></div><div>By commenting line where a new ImageRegionSplitterSlowDimension is instantiated [5][6] and updating the method "GetImageRegionSplitter / GetGlobalDefaultSplitter" to return 0 [7][8], the initialization can happen on demand instead of when ITK libraries are loaded.</div>
<div><br></div><div>An easy solution for us would be to ensure the "ITK_AUTOLOAD_PATH" environment variable is set in the application launcher for Windows and Linux application and set in Info.plist file associated with the application bundle on MacOSX [9]</div>
<div><br></div><div>To provide more details, within Slicer we set the CMake variable ITK_NO_IO_FACTORY_REGISTER_MANAGER before doing an "include(${ITK_USE_FILE}) so that IOFactory are loaded only by calling the method "itkFactoryRegistration" associated with a shared library we named ITKFactoryRegistration. This approach allowed us to disable the automatic registration of factory in selected part of the code. More details here [10]</div>
<div><br></div><div>It seems the new ITK commits 4c47e7d and defb9c1 prevent from completely leveraging the use of ITK_NO_IO_FACTORY_REGISTER_MANAGER variable, the code should probably be updated to consider this.</div>
<div><br></div><div><br></div><div>Let me know what you think.</div><div><br></div><div>Thanks</div><div>Jc</div><div><div><br></div><div><br></div><div>[1] <a href="https://github.com/Kitware/ITK/commit/4c47e7d" target="_blank">https://github.com/Kitware/ITK/commit/4c47e7d</a></div>
<div>[2] <a href="https://github.com/Kitware/ITK/commit/defb9c1" target="_blank">https://github.com/Kitware/ITK/commit/defb9c1</a></div><div>[3] <a href="https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L27" target="_blank">https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L27</a></div>
<div>[4] <a href="https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkObjectFactoryBase.cxx#L142-144" target="_blank">https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkObjectFactoryBase.cxx#L142-144</a></div>
<div>[5] <a href="https://github.com/Kitware/ITK/blob/defb9c1d084c8d55df61947587427839f9968ecf/Modules/IO/ImageBase/src/itkImageIOBase.cxx#L760" target="_blank">https://github.com/Kitware/ITK/blob/defb9c1d084c8d55df61947587427839f9968ecf/Modules/IO/ImageBase/src/itkImageIOBase.cxx#L760</a></div>
<div>[6] <a href="https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L27" target="_blank">https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L27</a></div>
<div>[7] <a href="https://github.com/Kitware/ITK/blob/defb9c1d084c8d55df61947587427839f9968ecf/Modules/IO/ImageBase/src/itkImageIOBase.cxx#L765" target="_blank">https://github.com/Kitware/ITK/blob/defb9c1d084c8d55df61947587427839f9968ecf/Modules/IO/ImageBase/src/itkImageIOBase.cxx#L765</a></div>
<div>[8] <a href="https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L32" target="_blank">https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L32</a></div>
<div>[9] <a href="http://www.herzbube.ch/blog/2009/01/how-set-environment-variables-mac-os-x-applications" target="_blank">http://www.herzbube.ch/blog/2009/01/how-set-environment-variables-mac-os-x-applications</a></div>
<div>[10] <a href="https://github.com/Slicer/Slicer/commit/03b8961" target="_blank">https://github.com/Slicer/Slicer/commit/03b8961</a><a href="https://github.com/Kitware/ITK/blob/4c47e7d672bad5d83b92c2df5f293cca618e2740/Modules/Core/Common/src/itkImageSource.cxx#L27" target="_blank"><font color="#222222"><br>
</font><br></a>-- </div><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
</div></div></div></div>
_______________________________________________<br>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>Kitware offers ITK Training Courses, for more information visit:<br><a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br><br>Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br><br>Follow this link to subscribe/unsubscribe:<br><a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</blockquote></div><br></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>+1 919 869 8849<br>
</div>