<div dir="ltr">Are these API breaking in the 4.4 release? If not, we can wait to fix them.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 15, 2013 at 2:02 PM, Johnson, Hans J <span dir="ltr"><<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Adding Ali to the conversation.<br>
<br>
Hans<br>
<div><div class="h5"><br>
<br>
-----Original Message-----<br>
From: Matt McCormick <<a href="mailto:matt.mccormick@kitware.com">matt.mccormick@kitware.com</a>><br>
Date: Monday, July 15, 2013 12:53 PM<br>
To: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
Cc: ITK <<a href="mailto:insight-developers@itk.org">insight-developers@itk.org</a>><br>
Subject: Re: [Insight-developers] Recent changes to Transforms break<br>
ITK's API<br>
<br>
Hi Bill,<br>
<br>
I have added your code in this patch:<br>
<br>
<a href="http://review.source.kitware.com/#/c/11961/" target="_blank">http://review.source.kitware.com/#/c/11961/</a><br>
<br>
It reproduces the compilation error.<br>
<br>
<br>
To overcome this limitation, I propose we:<br>
<br>
1) SetInput( TransformType * ) -> SetInput( LightObject * )<br>
2) Create a new TransformPrecisionFilter that can convert between<br>
transform precisions<br>
3) Internally convert between precisions if required in<br>
TransformFileWriter::Update()<br>
<br>
Thanks,<br>
Matt<br>
<br>
<br>
On Sun, Jul 14, 2013 at 3:50 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
wrote:<br>
> BTW, if I change the type to double it compiles.<br>
><br>
><br>
><br>
> On Sun, Jul 14, 2013 at 11:50 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
> wrote:<br>
>><br>
>> I think it works with 4.5.0(~ May 31). Probably fails because of this<br>
>> commit:<br>
>> <a href="http://review.source.kitware.com/#/c/11396/" target="_blank">http://review.source.kitware.com/#/c/11396/</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> On Sun, Jul 14, 2013 at 11:40 AM, Matt McCormick<br>
>> <<a href="mailto:matt.mccormick@kitware.com">matt.mccormick@kitware.com</a>> wrote:<br>
>>><br>
>>> Hi Bill,<br>
>>><br>
>>> Did this code with 4.4.0?<br>
>>><br>
>>> Thanks,<br>
>>> Matt<br>
>>><br>
>>> On Sun, Jul 14, 2013 at 11:31 AM, Bill Lorensen<br>
>>><<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
>>> wrote:<br>
>>> > Folks,<br>
>>> ><br>
>>> > When I compile the following code I get this compilation error:<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>>/home/lorensen/ProjectsGIT/ITKGerrit/Modules/Remote/WikiExamples/IO/Tran<br>
>>>sformFileWriter.cxx:<br>
</div></div>>>> > In function int main(int, char**)¹:<br>
>>> ><br>
>>> ><br>
>>>/home/lorensen/ProjectsGIT/ITKGerrit/Modules/Remote/WikiExamples/IO/Tran<br>
<div class="im">>>>sformFileWriter.cxx:20:<br>
>>> > error: no matching function for call to<br>
>>> ><br>
>>> ><br>
</div>>>>itk::TransformFileWriterTemplate<double>::SetInput(itk::SmartPointer<it<br>
>>>k::Rigid2DTransform<float><br>
>>> >>&)¹<br>
>>> ><br>
>>> ><br>
>>>/home/lorensen/ProjectsGIT/ITKGerrit/Modules/IO/TransformBase/include/it<br>
<div><div class="h5">>>>kTransformFileWriter.hxx:78:<br>
>>> > note: candidates are: void<br>
>>> > itk::TransformFileWriterTemplate<ScalarType>::SetInput(const<br>
>>> > itk::TransformBaseTemplate<TScalarType>*) [with ScalarType = double]<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>>------------------------------------------------------------------------<br>
>>>---------------------------<br>
>>> > #include "itkRigid2DTransform.h"<br>
>>> > #include "itkTransformFileWriter.h"<br>
>>> ><br>
>>> > int main(int argc, char *argv[])<br>
>>> > {<br>
>>> > std::string fileName;<br>
>>> > if(argc == 1) // No arguments were provided<br>
>>> > {<br>
>>> > fileName = "test.tfm";<br>
>>> > }<br>
>>> > else<br>
>>> > {<br>
>>> > fileName = argv[1];<br>
>>> > }<br>
>>> ><br>
>>> > typedef itk::Rigid2DTransform< float > TransformType;<br>
>>> > TransformType::Pointer transform = TransformType::New();<br>
>>> ><br>
>>> > itk::TransformFileWriter::Pointer writer =<br>
>>> > itk::TransformFileWriter::New();<br>
>>> > writer->SetInput(transform);<br>
>>> > writer->SetFileName(fileName);<br>
>>> > writer->Update();<br>
>>> ><br>
>>> > return EXIT_SUCCESS;<br>
>>> > }<br>
>>> ><br>
>>> ><br>
>>> > _______________________________________________<br>
>>> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> ><br>
>>> > Visit other Kitware open-source projects at<br>
>>> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> ><br>
>>> > Kitware offers ITK Training Courses, for more information visit:<br>
>>> > <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>>> ><br>
>>> > Please keep messages on-topic and check the ITK FAQ at:<br>
>>> > <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>>> ><br>
>>> > Follow this link to subscribe/unsubscribe:<br>
>>> > <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>>> ><br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Unpaid intern in BillsBasement at noware dot com<br>
><br>
><br>
><br>
><br>
> --<br>
> Unpaid intern in BillsBasement at noware dot com<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>
<br>
<br>
</div></div>________________________________<br>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
________________________________<br>
</blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</div>