<div dir="ltr">If the ITKReview module is enabled in the building process, it should behave the same as any other module in ITK, namely, the headers should be included.<div><br></div><div style>This patch is fixing the bug ( in which the module is not enabled by turning ITK_USE_REVIEW ON):</div>
<div><a href="http://review.source.kitware.com/#/c/12259/">http://review.source.kitware.com/#/c/12259/</a></div><div><br></div><div style>Will you mind double checking your build tree to make sure the ITKReview module is enabled?</div>
<div><br><div><br><div><br></div><div><br></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 15, 2013 at 11:02 AM, Williams, Norman K <span dir="ltr"><<a href="mailto:norman-k-williams@uiowa.edu" target="_blank">norman-k-williams@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">OK, so you would go from someone setting ITK_USE_REVIEW to setting<br>
Module_ITKReview, fair enough.<br>
<br>
I still don't understand why I can do an install from an ITK build and the<br>
headers in Modules/NonUnit/Review/include<br>
are not copied.<br>
<br>
This is the revision we're currently settled on, coincidentally one of<br>
your checkins:<br>
<br>
commit c3624fafeb15f042839a8e6c463970e75ad40777<br>
Merge: 74f8fbc 29e8b58<br>
Author: Matt McCormick <<a href="mailto:matt.mccormick@kitware.com">matt.mccormick@kitware.com</a>><br>
Date: Thu Jul 25 21:39:33 2013 -0400<br>
<br>
Merge topic 'yvvGaussian'<br>
<br>
29e8b58 ENH: YVV remote module - Add EXCLUDE_FROM_ALL option to<br>
itk_module.<br>
ef8069f ENH: Remote module: GPU and CPU Smoothing recursive YVV<br>
Gaussian Filter<br>
<br>
<br>
<br>
--<br>
Kent Williams <a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
<br>
<br>
On 8/15/13 9:44 AM, "Matt McCormick" <<a href="mailto:matt.mccormick@kitware.com">matt.mccormick@kitware.com</a>> wrote:<br>
<br>
>Hi Kent,<br>
><br>
>We are in the process of deprecating ITK_USE_REVIEW due to incorrect<br>
>and complicated interaction with the Module_ITKReview variable. Are<br>
>you observing this behavior with recent master?<br>
><br>
>Thanks,<br>
>Matt<br>
><br>
>On Thu, Aug 15, 2013 at 2:26 PM, Williams, Norman K<br>
><<a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a>> wrote:<br>
>> I don't have time to read through all of the CMake magic involved in ITK<br>
>> Modularization, so I'm hoping someone on the list knows what's up: Some<br>
>> projects that succeed when built against an ITK build tree fail when<br>
>>built<br>
>> against an ITK install, because they use headers from Review. For<br>
>>example<br>
>> itkLabelGeometryImageFilter.h<br>
>><br>
>> Is there something that is suppressing the installation of the<br>
>> NonUnit/Review stuff?<br>
>><br>
>> --<br>
>> Kent Williams <a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> ________________________________<br>
>> Notice: This UI Health Care e-mail (including attachments) is covered<br>
>>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is<br>
>>confidential and may be legally privileged. If you are not the intended<br>
>>recipient, you are hereby notified that any retention, dissemination,<br>
>>distribution, or copying of this communication is strictly prohibited.<br>
>>Please reply to the sender that you have received the message in error,<br>
>>then delete it. Thank you.<br>
>> ________________________________<br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>
<br>
<br>
________________________________<br>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
________________________________<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div><br></div>---------------------------------------------<br><b>Xiaoxiao Liu</b>, Ph.D.<div><div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">R & D Engineer</span></font></div>
<div><div><a href="http://www.kitware.com/" target="_blank">Kitware Inc</a>.</div></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px">Clifton Park, NY</span><div><div>Phone: (518) 881-4924 or <span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">(518) 371-3971 x124</span></div>
<div><font face="Verdana, Arial, Helvetica, sans-serif"><span style="line-height:31px;font-size:x-small"><br></span></font></div></div></div></div></div>
</div>