<div dir="ltr">Hi Matt, Kent, <br><br>Thanks for letting the Slicer community know about the fix.<br><br>For the coming Slicer release, I will just cherry pick that specific change. Then, we could think about using the ITK remove modules. I just created an issue to keep track of it. See [1] Could you, Hans or Matt take care of submitting a pull request on Slicer ?<br>
<div class="gmail_extra"><br></div><div class="gmail_extra">Thanks<br></div><div class="gmail_extra">Jc<br><br>[1] <a href="http://na-mic.org/Mantis/view.php?id=3410">http://na-mic.org/Mantis/view.php?id=3410</a><br></div>
<div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 20, 2013 at 6:25 PM, Matt McCormick <span dir="ltr"><<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Kent,<br>
<br>
My vote is of course for B) -- we can add it to ITK's release branch<br>
soon after, and Slicer can use the updated release branch SHA.<br>
<br>
Thanks,<br>
Matt<br>
<div class=""><div class="h5"><br>
On Fri, Sep 20, 2013 at 9:25 PM, Williams, Norman K<br>
<<a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a>> wrote:<br>
> If I was just proposing a change to ITK this would be a bit easier -- I'd<br>
> just go through ITK's gerrit review system.<br>
><br>
> As it is this has a few more moving parts.<br>
><br>
> The problem was that MGHImageIO was writing out Image origins incorrectly.<br>
> Eun Young Kim discovered this while using SimpleITK within Slicer to read<br>
> and write MGZ files.<br>
><br>
> I re-wrote the 'WriteHeader' code where it converts the origin from ITK<br>
> conventions to FreeSurfer conventions, so the conversion code on the Write<br>
> side matches that on the Read side.<br>
><br>
> But getting this incorporated back into Slicer and ITK has more than one<br>
> step.<br>
><br>
> ITK:<br>
> 1. Merge the pull request into the Slicer/itkMGHImageIO repository on<br>
> github. The pull request is here:<br>
> <a href="https://github.com/Slicer/itkMGHImageIO/pull/3" target="_blank">https://github.com/Slicer/itkMGHImageIO/pull/3</a><br>
> 2. Get a topic through ITK Gerrit to update the SHA to match the revision<br>
> of my change.<br>
><br>
> SLICER:<br>
><br>
> Slicer has an older version of MGHImageIO than the one used by ITK; I<br>
> don't know if Slicer uses this and turns on the MGHImageIO remote module<br>
> when it builds ITK.<br>
> A) If Slicer uses the old code in Slicer/Libs/MGHImageIO, then this should<br>
> be replaced by the code in the Github repository above.<br>
> B) If Slicer uses the ITK version via the ITK remote module for<br>
> itkMGHImageIO, then Š well there's a bit of a problem, as when the fix<br>
> gets propogated through into ITK, it will be at the Development head for<br>
> ITK, and be some time before it's part of a ITK Minor version release.<br>
> Slicer no doubt picks a particular ITK version and sticks with it until a<br>
> newer version comes along with sufficient new functionality and bug fixes<br>
> to justify re-validating ITK all over again with Slicer.<br>
><br>
> So I have the fix, I just need to know what I need to do for it to be<br>
> pushed where it needs to be.<br>
><br>
><br>
> --<br>
> Kent Williams <a href="mailto:norman-k-williams@uiowa.edu">norman-k-williams@uiowa.edu</a><br>
><br>
><br>
><br>
><br>
><br>
><br>
> ________________________________<br>
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
> ________________________________<br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br>
</div></div>