<div dir="ltr"><div>Luis, the current code flow diagram was suggested in <a href="http://www.kitware.com/blog/home/post/557">http://www.kitware.com/blog/home/post/557</a> ( in the bottom). Probably needs some updates after the discussion.<br>
</div><div><br></div><div>Agree with you all that a collection of related class/filter contributions can be submitted a remote module for fast outreach (similar to the slicer extension modules).</div><div>A single purposed class/filter that fit into existing internal modules should go directly to Gerrit review (does not make much sense to warp it as a single class module to go to IJ).</div>
<div><br></div><div>The remote module mechanism is a great way to extend the toolkit ( similar to the extension modules in slicer) without dividing the maintenance efforts from the core library.<br></div><div>Brad (L), we could add a "remote" group cmake option to make group testing those remote modules easier, if you think this is helpful. But the idea of mixing remote and internal modules together in the same group does not sound very appealing to me.</div>
<div><br></div><div>At last, whatever strategy we agreed on in the end, don't forget to document it well for people to refer to.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 16, 2014 at 11:30 AM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Luis,<div><br></div><div>I agree that we should take a step back and look at things.</div>
<div><br></div><div>Particularly, look at the infrastructure that is needed to help support contributed code, and prioritize what needs to be done to effectively review, maintain and test contributed code.</div><div><br></div>
<div>Brad</div><div><div class="h5"><div><br><div><div>On Jan 16, 2014, at 11:05 AM, Luis Ibanez <<a href="mailto:luis.ibanez@kitware.com" target="_blank">luis.ibanez@kitware.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr">Perhaps one way to approach the discussion is to actually<div>draw a map of the the paths that new code can take in the</div><div>current ITK landscape. Different types of code would follow</div><div>different paths.<br>
<div><br></div><div>Then we can better evaluate whether the workflows are</div><div>appropriate, and whether we need to refine the tools that</div><div>go with them.</div><div><br></div><div>I agree with Brad K, in that what we first need to address</div>
<div>the governance of code flow, and then we will have a </div><div>better perspective for discussing the actual mechanisms.</div><div><br></div><div>Creating a Contrib group, doesn't quite address the more</div></div>
<div>fundamental issue that we need to recruit more volunteers</div><div>developers to actually review and improve code. </div><div><br></div><div>We already have the backlog of the Review directory...</div><div><br></div>
<div><br></div><div> Luis</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 16, 2014 at 10:51 AM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Brad K, Bill,<br>
<br>
It's not clear from your(s) comments if you are in favor of using remote modules for all new modules or not?<br>
<br>
Or if small new contribution like a single class should be added as separate module or integrated into the appropriate existing module?<br>
<br>
Thanks for the clarification,<br>
Brad<br>
<div><div><br>
On Jan 16, 2014, at 10:38 AM, Brad King <<a href="mailto:brad.king@kitware.com" target="_blank">brad.king@kitware.com</a>> wrote:<br>
<br>
> On 01/16/2014 10:18 AM, Bradley Lowekamp wrote:<br>
>> these contributed modules are not reviewable in gerrit, are no<br>
>> automatically tested in gerrit, and are not tested in the dashboard.<br>
><br>
> That is a limitation of the review/testing infrastructure that should<br>
> be overcome by technical means rather than worked around with means<br>
> known to fail in the past. Just look back at the Review directory<br>
> prior to modularization. It was huge and barely maintained.<br>
><br>
>> Additionally, the other other goal it to have users have sense of ownership<br>
>> and responsibility for the code contributed and reduce the limited<br>
>> maintenance resources.<br>
><br>
> How does labeling something "contrib" (a second-class designation) give<br>
> a contributor a sense of acceptance into the community? We should<br>
> encourage contributors to maintain their work as first-class<br>
> participants.<br>
><br>
>> Also, everyone things there code is great and thinks it should get into ITK.<br>
>> With the current nebulous Community lead approach no direction or editorial<br>
>> leadership can occur.<br>
><br>
> This is a problem best solved by refining the governance model.<br>
><br>
> -Brad K<br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com/" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com/" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
_______________________________________________<br>
Community mailing list<br>
<a href="mailto:Community@itk.org" target="_blank">Community@itk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/community" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/community</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br>_______________________________________________<br>
Community mailing list<br>
<a href="mailto:Community@itk.org">Community@itk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/community" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/community</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div><br></div>---------------------------------------------<br><b>Xiaoxiao Liu</b>, Ph.D.<div><div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">R & D Engineer</span></font></div>
<div><div><a href="http://www.kitware.com/" target="_blank">Kitware Inc</a>.</div></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px">Clifton Park, NY</span><div><div>Phone: (518) 881-4924 or <span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">(518) 371-3971 x124</span></div>
<div><font face="Verdana, Arial, Helvetica, sans-serif"><span style="line-height:31px;font-size:x-small"><br></span></font></div></div></div></div></div>
</div>