Bill,<div><br></div><div>I think the idea is to disable the cell-centered functionality until after the release.  I.e. the code will be in, but not enabled in the CMake options.  Is this an acceptable alternative?</div><div>
<br></div><div>- Wes</div><div><br><div class="gmail_quote">On Wed, May 20, 2009 at 7:20 PM, Bill Lorensen <span dir="ltr">&lt;<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I understand the current situation. I do believe however that we<br>
should validate the new techniques. Regression testing is meant to<br>
track changes in the code but they do not validate the code. Before we<br>
release ITK with these new capabilities I think we should make sure<br>
the code is correct. Even if this means we have to delay the release.<br>
<br>
Bill<br>
<br>
On Wed, May 20, 2009 at 1:57 PM, Michel Audette<br>
<div><div></div><div class="h5">&lt;<a href="mailto:michel.audette@kitware.com">michel.audette@kitware.com</a>&gt; wrote:<br>
&gt; Hi Bill,<br>
&gt;<br>
&gt; so far we are only modifying existing tests that were failing. The following<br>
&gt; tests include new code,<br>
&gt;<br>
&gt; Code/BasicFilters/itkExpandImageFilterTest.cxx:<br>
&gt; Code/BasicFilters/itkVectorExpandImageFilterTest.cxx:<br>
&gt; Code/Common/itkBSplineDeformableTransformTest2.cxx<br>
&gt;<br>
&gt; which assume pixel-centeredness. Moreover, many other tests have new<br>
&gt; regression data committed, and ctest selects the appropriate data set<br>
&gt; depending on the value of these flags.<br>
&gt;<br>
&gt; Best wishes,<br>
&gt;<br>
&gt; Michel<br>
&gt;<br>
&gt; On Wed, May 20, 2009 at 1:48 PM, Bill Lorensen &lt;<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>&gt;<br>
&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Do we have a test that validates the centered pixel and portable round<br>
&gt;&gt; options? For example, a 1D example that can be manual verified.<br>
&gt;&gt;<br>
&gt;&gt; Bill<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; On Wed, May 20, 2009 at 1:12 PM, Michel Audette<br>
&gt;&gt; &lt;<a href="mailto:michel.audette@kitware.com">michel.audette@kitware.com</a>&gt; wrote:<br>
&gt;&gt; &gt; Dear members of the Insight Community,<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; in response to bug 6558, Luis and I have implemented some changes that<br>
&gt;&gt; &gt; produce pixel-centered coordinates, as well as a few other needed<br>
&gt;&gt; &gt; refinements, which are enabled by the flags<br>
&gt;&gt; &gt; ITK_USE_CENTERED_PIXEL_COORDINATES_CONSISTENTLY,<br>
&gt;&gt; &gt; ITK_USE_REGION_VALIDATION_IN_ITERATORS and<br>
&gt;&gt; &gt; ITK_USE_PORTABLE_ROUND<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; With the flags turned off, the code behaves as before, with no failing<br>
&gt;&gt; &gt; tests. With the flags turned on there are still a number of failing<br>
&gt;&gt; &gt; tests,<br>
&gt;&gt; &gt; that are related to these new coordinates, and which have been whittled<br>
&gt;&gt; &gt; down<br>
&gt;&gt; &gt; from more than 25 to 14 currently.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Nonetheless, we would like to get rid of as many of these as we can by<br>
&gt;&gt; &gt; next<br>
&gt;&gt; &gt; Monday, for the upcoming release of ITK, and consequently, we would<br>
&gt;&gt; &gt; respectfully ask interested members of the community to lend a hand with<br>
&gt;&gt; &gt; the<br>
&gt;&gt; &gt; remaining tests.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; I will be submitting an Experimental ctest on a regular basis, with the<br>
&gt;&gt; &gt; signature metropolis-pixelcentered.kitware<br>
&gt;&gt; &gt; Currently the failing tests are the following.<br>
&gt;&gt; &gt;     169 - itkSampleSelectiveMeanShiftBlurringFilterTest (Failed)<br>
&gt;&gt; &gt;     340 - itkMedialNodeCorrespondencesTest (Failed)<br>
&gt;&gt; &gt;     543 - itkImportImageTest (Failed)<br>
&gt;&gt; &gt;     572 - itkNonThreadedShrinkImageTest (Failed)<br>
&gt;&gt; &gt;     594 - itkShrinkImageTest (Failed)<br>
&gt;&gt; &gt;     615 - itkStreamingImageFilterTest2 (Failed)<br>
&gt;&gt; &gt;     630 - itkWarpImageFilterTest (Failed)<br>
&gt;&gt; &gt;     632 - itkWarpVectorImageFilterTest (Failed)<br>
&gt;&gt; &gt;     800 - itkMattesMutualInformationImageToImageMetricTest (Failed)<br>
&gt;&gt; &gt;     801 - itkMattesMutualInformationImageToImageMetricTest2 (Failed)<br>
&gt;&gt; &gt;     802 - itkMattesMutualInformationImageToImageMetricTest3 (Failed)<br>
&gt;&gt; &gt;     803 - itkMattesMutualInformationImageToImageMetricTest4 (Failed)<br>
&gt;&gt; &gt;     816 - itkMultiResolutionPDEDeformableRegistrationTest (Failed)<br>
&gt;&gt; &gt;     1470 - ResampleImageFilter9Test (Failed)<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; I plan to work on failing tests relating to the itkShrinkImageFilter<br>
&gt;&gt; &gt; class.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Thank you for your kind consideration.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Best wishes,<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Michel<br>
&gt;&gt; &gt; --<br>
&gt;&gt; &gt; Michel Audette, Ph.D.<br>
&gt;&gt; &gt; R &amp; D Engineer,<br>
&gt;&gt; &gt; Kitware Inc.,<br>
&gt;&gt; &gt; Chapel Hill, N.C.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; _______________________________________________<br>
&gt;&gt; &gt; Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Visit other Kitware open-source projects at<br>
&gt;&gt; &gt; <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Please keep messages on-topic and check the ITK FAQ at:<br>
&gt;&gt; &gt; <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Follow this link to subscribe/unsubscribe:<br>
&gt;&gt; &gt; <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; --<br>
&gt; Michel Audette, Ph.D.<br>
&gt; R &amp; D Engineer,<br>
&gt; Kitware Inc.,<br>
&gt; Chapel Hill, N.C.<br>
&gt;<br>
&gt;<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at: <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Wesley D. Turner, Ph.D.<br>Kitware, Inc.<br>R&amp;D Engineer<br>28 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: 518-371-3971 x120<br>
</div>