<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Dear Adarsh,<div> you are right. This was a bug both in the code and the test that didn't test for it.</div><div>I just committed checks for the cases where number of steps is 0 and 1</div><div>(now the filter does nothing in the first case and only runs the minimum scale in </div><div>the second). I also modified the test to test against these situations.</div><div>Thanks for reporting the problem</div><div><br></div><div>Luca</div><div><br></div><div><br><div><div>On Jun 19, 2009, at 7:49 AM, <a href="mailto:ramasa@rpi.edu">ramasa@rpi.edu</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>Hello everyone,<br><br>I was working with the MultiScaleHessianBasedMeasureImageFilter , that is <br>part of the Code/Review. I am using ITK 3.12.0. I think there is a small<br>error in the way the code runs through the sigma values in the<br>MultiScaleHessianBasedMeasureImageFilter.txx file. If a user enters the<br>number of steps to be 1, then the loop would go on forever because of the <br>following code section in the function ComputeSigmaValue( int ) in the<br>same (.txx) file:<br><br>if (m_NumberOfSigmaSteps < 2)<br> {<br> return m_SigmaMinimum;<br> }<br><br>The while loop (looping through sigma) checks that sigma be less than or<br>equal to m_SigmaMaximum. This will always be true if the user entered<br>SigmaMaximum >= SigmaMinimum, and numberOfSigmaSteps = 1. <br><br>Thanks,<br>Adarsh K. Ramasubramonian,<br>Rensselaer Polytechnic Institute<br>Troy NY<br><br><br>_____________________________________<br>Powered by <a href="http://www.kitware.com">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br><br>Please keep messages on-topic and check the ITK FAQ at: <a href="http://www.itk.org/Wiki/ITK_FAQ">http://www.itk.org/Wiki/ITK_FAQ</a><br><br>Follow this link to subscribe/unsubscribe:<br><a href="http://www.itk.org/mailman/listinfo/insight-users">http://www.itk.org/mailman/listinfo/insight-users</a><br></div></blockquote></div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Luca Antiga, PhD</div><div>Head, Medical Imaging Unit,<br>Biomedical Engineering Department,<br>Mario Negri Institute.<br>mail: Villa Camozzi, 24020, Ranica (BG), Italy<br>phone: +39 035 4535-381<br>email: <a href="mailto:antiga@marionegri.it">antiga@marionegri.it</a><br>web: <a href="http://villacamozzi.marionegri.it/~luca">http://villacamozzi.marionegri.it/~luca</a></div></div></div></div></div></div></span></div></span></div></span> </div><br></div></body></html>