Proposals:Increasing WrapITK Coverage: Difference between revisions

From KitwarePublic
Jump to navigationJump to search
No edit summary
Line 230: Line 230:


* It's not possible to include itkFFTWComplexToComplexImageFilter.h before itkFFTWComplexToComplexImageFilter.h
* It's not possible to include itkFFTWComplexToComplexImageFilter.h before itkFFTWComplexToComplexImageFilter.h
* MagnitudeAndPhaseToComplexImageFilter was not reporting the right name
* ComposeRGBAImageFilter, MagnitudeAndPhaseToComplexImageFilter and RealAndImaginaryToComplexImageFilter not reporting the right name
* Strange template parameters for FFT filters
* Strange template parameters for FFT filters

Revision as of 10:38, 5 October 2008

Motivation

You may know that WrapITK has greatly enhanced the filter coverage, compared to what was previously available in tcl, java and python. Currently, 66% of the filters in ITK are usable in WrapITK. In the future, the goal is to reach 100% of filter coverage. This is a quite difficult task for a single person, because it requires a quite good knowledge of the whole ITK, to be able to select, for all the classes, the relevant template parameters to instantiate. I made my best to complete this task, but obviously, I can't go further, because I'm not able to make a decision on the remaining non wrapped filters.

I think that the weekly tcon can be a great place to select the template parameters needed to instantiate the missing filters in WrapITK. For many of the filters, I'm quite sure the right template parameters to use are obvious for many of us, and that they only need to be collected. With those data, I would be able to implement the wrappers and to add them in WrapITK. Also, some of the filters may not be of direct interest for the user, because they are intended to be used only internally in some other code, or because they can only be used as a superclass (like UnaryFunctorImageFilter). In that case, they should be added in the excluded filters list for the filter coverage.

A good goal, for the next release, would be to cover 80% of ITK's filter, which means 51 new filters added in WrapITK or in the excluded filters list. 51 filters may look like a big number of classes (and it is, for the final python/tcl/java user), but many of the remaining filters seems similar, so it should be easy to choose the template parameters for a group of filters, instead of processing them one by one.

Also, note that adding new stuff in WrapITK would not only benefit to WrapITK users: because building a class in WrapITK builds every methods in that class, we have found many bugs in ITK code during the addition of new classes in WrapITK in the past. It is likely that we would uncover a few more bugs by adding new classes, bugs which won't be found by final users.

List of Unwrapped Filters

(Add to list below with template parameters and remove from this list)

  • BSplineScatteredDataPointSetToImageFilter (Luis)
  • BalloonForceFilter
  • BayesianClassifierImageFilter (Luis)
  • BayesianClassifierInitializationImageFilter (Luis)
  • BinaryMaskToNarrowBandPointSetFilter (Luis)
  • BloxBoundaryPointImageToBloxBoundaryProfileImageFilter
  • BloxBoundaryPointToCoreAtomImageFilter
  • BloxBoundaryProfileImageToBloxCoreAtomImageFilter
  • ChainCodeToFourierSeriesPathFilter
  • ConformalFlatteningMeshFilter (Alex)
  • ConnectedRegionsMeshFilter (Alex)
  • ContourExtractor2DImageFilter (Luis)
  • CurvatureRegistrationFilter
  • DeformableMesh3DFilter (Alex)
  • DeformableSimplexMesh3DBalloonForceFilter (Alex)
  • DeformableSimplexMesh3DFilter (Alex)
  • DeformableSimplexMesh3DGradientConstraintForceFilter (Alex)
  • DeformationFieldJacobianDeterminantFilter (Luis)
  • DifferenceOfGaussiansGradientImageFilter (Luis)
  • DiffusionTensor3DReconstructionImageFilter
  • EigenAnalysis2DImageFilter (Luis)
  • ExtensionVelocitiesImageFilter
  • ExtractOrthogonalSwath2DImageFilter
  • FEMRegistrationFilter
  • FastMarchingExtensionImageFilter (Luis)
  • FiniteDifferenceSparseImageFilter (Luis)
  • GradientVectorFlowImageFilter (Luis)
  • HardConnectedComponentImageFilter
  • HistogramToEntropyImageFilter (Luis)
  • HistogramToImageFilter (Luis)
  • HistogramToIntensityImageFilter (Luis)
  • HistogramToLogProbabilityImageFilter (Luis)
  • HistogramToProbabilityImageFilter (Luis)
  • HoughTransform2DCirclesImageFilter
  • HoughTransform2DLinesImageFilter
  • ImageAndPathToImageFilter
  • ImageToMeshFilter (Alex)
  • ImageToParametricSpaceFilter (Luis)
  • ImageToPathFilter
  • ImageToVectorImageFilter (Luis)
  • ImplicitManifoldNormalVectorFilter
  • InteriorExteriorMeshFilter
  • InterpolateImagePointsFilter
  • InverseDeformationFieldImageFilter (Luis)
  • IsoContourDistanceImageFilter (Luis)
  • IterativeInverseDeformationFieldImageFilter (Luis)
  • KLMRegionGrowImageFilter (Luis)
  • ListSampleToHistogramFilter (Luis)
  • MRFImageFilter
  • MRIBiasFieldCorrectionFilter
  • MaskNeighborhoodOperatorImageFilter
  • NarrowBandCurvesLevelSetImageFilter (Luis)
  • NeighborhoodOperatorImageFilter
  • NormalizedCorrelationImageFilter
  • OrthogonalSwath2DPathFilter
  • ParametricSpaceToImageSpaceMeshFilter
  • PathAndImageToPathFilter
  • PathToChainCodePathFilter
  • PathToImageFilter
  • PathToPathFilter
  • PointSetToImageFilter (Luis)
  • PolylineMask2DImageFilter
  • PolylineMaskImageFilter
  • QuadEdgeMeshCleanFilter (Alex)
  • QuadEdgeMeshDecimationFilter (Alex)
  • QuadEdgeMeshDelaunayConformingFilter (Alex)
  • QuadEdgeMeshEdgeMergeDecimationFilter (Alex)
  • QuadEdgeMeshNormalFilter (Alex)
  • QuadEdgeMeshToQuadEdgeMeshFilter (Alex)
  • RGBGibbsPriorFilter (Luis)
  • ReinitializeLevelSetImageFilter (Luis)
  • SampleMeanShiftBlurringFilter
  • SampleMeanShiftClusteringFilter
  • SampleSelectiveMeanShiftBlurringFilter
  • SampleToHistogramProjectionFilter
  • ScalarImageKmeansImageFilter (Luis)
  • ScalarToArrayCastImageFilter (Luis)
  • SimplexMeshAdaptTopologyFilter (Alex)
  • SimplexMeshToTriangleMeshFilter (Alex)
  • SpatialFunctionImageEvaluatorFilter
  • SpatialObjectToPointSetFilter
  • SymmetricEigenAnalysisImageFilter (Luis)
  • TensorFractionalAnisotropyImageFilter
  • TensorRelativeAnisotropyImageFilter
  • TransformMeshFilter (Luis)
  • TriangleMeshToBinaryImageFilter (Alex)
  • TriangleMeshToSimplexMeshFilter (Alex)
  • UnsharpMaskLevelSetImageFilter
  • VectorConfidenceConnectedImageFilter (Luis)
  • VectorConnectedComponentImageFilter
  • VectorCurvatureAnisotropicDiffusionImageFilter (Luis)
  • VectorExpandImageFilter
  • VectorGradientAnisotropicDiffusionImageFilter (Luis)
  • VectorGradientMagnitudeImageFilter (Luis)
  • VectorNeighborhoodOperatorImageFilter
  • VectorRescaleIntensityImageFilter (Luis)
  • VectorThresholdSegmentationLevelSetImageFilter (Luis)
  • VoronoiPartitioningImageFilter
  • VoronoiSegmentationRGBImageFilter
  • WarpMeshFilter (Alex)
  • WarpVectorImageFilter (Luis)
  • WrapPadImageFilter

List of Filters with Template Parameters Waiting to be Wrapped

(Add to list below when in WrapITK and remove from this list)

  • DiffeomorphicDemonsRegistrationFilter
itk::DiffeomorphicDemonsRegistrationFilter< itk::Image<float,2>, itk::Image<float,2>, itk::Image<itk::Vector<float,2>,2> >
itk::DiffeomorphicDemonsRegistrationFilter< itk::Image<float,3>, itk::Image<float,3>, itk::Image<itk::Vector<float,3>,3> >
  • DisplacementFieldJacobianDeterminantFilter
itk::DisplacementFieldJacobianDeterminantFilter< itk::Image<itk::Vector<float,2>,2>, float >
itk::DisplacementFieldJacobianDeterminantFilter< itk::Image<itk::Vector<float,2>,2>, double >
itk::DisplacementFieldJacobianDeterminantFilter< itk::Image<itk::Vector<float,3>,3>, float >
itk::DisplacementFieldJacobianDeterminantFilter< itk::Image<itk::Vector<float,3>,3>, double >
  • ExponentialDeformationFieldImageFilter
itk::ExponentialDeformationFieldImageFilter< itk::Image<itk::Vector<float,2>,2>, itk::Image<itk::Vector<float,2>,2>
itk::ExponentialDeformationFieldImageFilter< itk::Image<itk::Vector<float,3>,3>, itk::Image<itk::Vector<float,3>,3>


  • FastSymmetricForcesDemonsRegistrationFilter
itk::FastSymmetricForcesDemonsRegistrationFilter< itk::Image<float,2>, itk::Image<float,2>, itk::Image<itk::Vector<float,2>,2> >
itk::FastSymmetricForcesDemonsRegistrationFilter< itk::Image<float,3>, itk::Image<float,3>, itk::Image<itk::Vector<float,3>,3> >
  • GridForwardWarpImageFilter
itk::GridForwardWarpImageFilter< itk::Image<itk::Vector<float,2>,2>, itk::Image<unsigned char,2> >
itk::GridForwardWarpImageFilter< itk::Image<itk::Vector<float,3>,3>, itk::Image<unsigned char,3> >


  • VectorResampleImageFilter
itk::VectorResampleImageFilter< itk::Image<itk::Vector<float,2>,2>, itk::Image<itk::Vector<float,2>,2> >
itk::VectorResampleImageFilter< itk::Image<itk::Vector<float,3>,3>, itk::Image<itk::Vector<float,3>,3> >

List of excluded filters

(The filters to NOT wrap)

  • DeformationFieldJacobianDeterminantFilter (useless)
  • WarpJacobianDeterminantFilter (deprecated)
  • MatrixIndexSelectionImageFilter (matrix as pixel type is not currently used anywhere in WrapITK)
  • GetAverageSliceImageFilter (same features as projection filters)
  • GradientImageToBloxBoundaryPointImageFilter
  • JoinImageFilter (produce warnings, because it use an image with a higher dimension than the in/output image)
  • MaskedMovingHistogramImageFilter (base class unusable without the moving histogram type provided by the subclasses)
  • SimpleFuzzyConnectednessRGBImageFilter (patented)
  • SimpleFuzzyConnectednessScalarImageFilter (patented)
  • MeshToMeshFilter (base class, useless alone. Will see later if it must be wrapped or not)
  • VectorFuzzyConnectednessImageFilter (patented)

List of filters added to WrapITK

(Filters recently wrapped)

  • FFTComplexToComplexImageFilter (Gaetan)
  • FFTWComplexToComplexImageFilter (Gaetan)
  • MagnitudeAndPhaseToComplexImageFilter (Gaetan)
  • RealAndImaginaryToComplexImageFilter (Gaetan)
  • HessianRecursiveGaussianImageFilter< TInputImage, TOutputImage >
    • Hessian3DToVesselnessMeasureImageFilter< Image<ScalarPixelType, Dimension> >
    • Use the default for TOutputImage (the default is expected by Hessian3DToVesselnessMeasureImageFilter)
WRAP_CLASS("itk::HessianRecursiveGaussianImageFilter" POINTER)

  WRAP_IMAGE_FILTER_USIGN_INT(1)
  WRAP_IMAGE_FILTER_SIGN_INT(1)
  WRAP_IMAGE_FILTER_REAL(1)

END_WRAP_CLASS()
  • Hessian3DToVesselnessMeasureImageFilter< TPixel >
    • Hessian3DToVesselnessMeasureImageFilter< ScalarPixelType >
WRAP_CLASS("itk::Hessian3DToVesselnessMeasureImageFilter" POINTER)

  FOREACH(t ${WRAP_ITK_SCALAR})
    WRAP_TEMPLATE("${ITKM_${t}}" "${ITKT_${t}}")
  ENDFOREACH(t)

END_WRAP_CLASS()
  • ComposeRGBAImageFilter< TInputImage, TOutputImage >
    • ComposeRGBAImageFilter< Image<ScalarPixelType, Dimension>, Image<RGBAPixel, Dimension> >
    • See ComposeRGBImageFilter, need to add WRAP_ITK_RGBA to WrapBasicTypes.cmake
WRAP_CLASS("itk::ComposeRGBAImageFilter" POINTER)

  IF(WRAP_rgba_unsigned_char AND WRAP_unsigned_char)
    WRAP_IMAGE_FILTER_TYPES(UC RGBAUC) # NEED TO ADD RGBA
  ENDIF(WRAP_rgba_unsigned_char AND WRAP_unsigned_char)
  
  IF(WRAP_rgba_unsigned_short AND WRAP_unsigned_short)
    WRAP_IMAGE_FILTER_TYPES(US RGBAUS) # NEED TO ADD RGBA
  ENDIF(WRAP_rgba_unsigned_short AND WRAP_unsigned_short)

END_WRAP_CLASS()
  • FastMarchingUpwindGradientImageFilter<TLevelSet, TSpeedImage>
    • FastMarchingUpwindGradientImageFilter< Image<ScalarPixelType, Dimension>, Image<ScalarPixelType, Dimension> >
    • Same template parameters as FastMarchingImageFilter
WRAP_CLASS("itk::FastMarchingUpwindGradientImageFilter" POINTER)
  #WRAP_IMAGE_FILTER_USIGN_INT(2)
  #WRAP_IMAGE_FILTER_SIGN_INT(2)
  WRAP_IMAGE_FILTER_REAL(2)
END_WRAP_CLASS()
  • ZeroCrossingBasedEdgeDetectionImageFilter< TInputImage, TOutputImage >
    • ZeroCrossingBasedEdgeDetectionImageFilter< Image<ScalarPixelType, Dimension>, Image<ScalarPixelType, Dimension> >
WRAP_CLASS("itk::ZeroCrossingBasedEdgeDetectionImageFilter" POINTER)

  WRAP_IMAGE_FILTER_REAL(2 2+)

END_WRAP_CLASS()

Problem found in ITK

Just to show that WrapITK can help to find bugs ;-)

  • It's not possible to include itkFFTWComplexToComplexImageFilter.h before itkFFTWComplexToComplexImageFilter.h
  • ComposeRGBAImageFilter, MagnitudeAndPhaseToComplexImageFilter and RealAndImaginaryToComplexImageFilter not reporting the right name
  • Strange template parameters for FFT filters
Retrieved from "https://public.kitware.com/Wiki/index.php?title=Proposals:Increasing_WrapITK_Coverage&oldid=13720"