Difference between revisions of "ITK/Gerrit/ReviewPrimer"

From KitwarePublic
< ITK‎ | Gerrit
Jump to navigationJump to search
Line 7: Line 7:
  
 
==Select an open change==
 
==Select an open change==
 +
The primary review site for Gerrit/ITK is [http://review.source.kitware.com http://review.source.kitware.com].  From this page, changes may be reviewed, etc.  Our review will be of [http://review.source.kitware.com/79 Change I5e76253f: Removed unecessary commented out debugging code] commited on Sept. 17, 2010.  Because Gerrit is dynamic, this primer will include many screenshots, [http://www.urbandictionary.com/define.php?term=YMMV YMMV].
 +
 +
[[File:ReviewOverview.png]]

Revision as of 17:02, 20 September 2010

Gerrit code reviews can be relatively straightforward, but also give the reviewer a chance to look deep into proposed changes building and testing those changes locally. This primer is intended to guide the reader through the process of a deep review of a code change.

Prerequisites

This primer assumes a working knowledge of how to build ITK. No details will be given as to how to build and test the code (but they can be found here). This primer also assumes a working knowledge of git. Please see the ITK git pages and/or git books (ProGit, Community Book, or Version Control withGit).

Also required is a Gerrit change to review. We will go through a real life code review of a change submitted to Gerrit.

Select an open change

The primary review site for Gerrit/ITK is http://review.source.kitware.com. From this page, changes may be reviewed, etc. Our review will be of Change I5e76253f: Removed unecessary commented out debugging code commited on Sept. 17, 2010. Because Gerrit is dynamic, this primer will include many screenshots, YMMV.

ReviewOverview.png