[ITK] [ITK-dev] Sphinx and ITK WIki example regression

Bill Lorensen bill.lorensen at gmail.com
Tue Aug 18 09:00:29 EDT 2015


Folks,

The addition of the new math equality checks caused Sphinx and Wiki
examples using itkCustomColormapFunction to segfault.

I submitted a patch to fix this.

However, this brings up an issue. I'm sorry now that I did not review
the math equality check changes.

I see the need for fuzzy math comparison for real types, but why for
integral types?

What is the justification for replacing
int i;
int j;

if (i == j) …

with
if (Math::AlmostEquals(i,j)) …
of
if(Math::AlmostEquals(i,j))...

-- 
Unpaid intern in BillsBasement at noware dot com
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers


More information about the Community mailing list