[Insight-developers] STEP 1: REMOVE UNTESTED CODE BY FRIDAY AUGUST 8, 9:00 EST

Joshua Cates cates at sci . utah . edu
Tue, 5 Aug 2003 10:19:41 -0600 (MDT)


Hi Luis,

Be careful with this.  Things are sometimes more complicated than the
dashboard would suggest.  There are cases where files do not show up in
coverage, but are actually quite extensively used.  If you remove
itkNeighborhoodAlgorithm.h, for example, you will break almost all of the
basic filtering algorithms like anisotropic diffusion, morphology, etc. =20
A grep for "#include itkNeighborhoodAlgorithm.h" in BasicFilters returns a
list of more than 20 files, most of which are themselves heavily used and=
=20
tested.

Josh.

______________________________
 Josh Cates=09=09=09
 School of Computer Science=09
 University of Utah
 Email: cates at sci . utah . edu
 Phone: (801) 587-7697
 URL:   http://www . sci . utah . edu/~cates


On Tue, 5 Aug 2003, Luis Ibanez wrote:

>=20
> The files/classes in the list below will be removed
> from the Insight CVS repository on
>=20
>             Friday August 8  9:00 EST
>=20
> Reason for removal:
>=20
>               Code with 0% coverage
>=20
> Philosopical principle:
>=20
>       "If it is not tested, it is broken"
>=20
> If you have any professional or emotional attachements
> to any of the files in this list and would like to
> prevent its removal from the repository, please add
> a test for this code in the Insight/Testing directory.
>=20
> New testing must compile. CVS write access will be
> removed for anyone commiting non-compiling tests.
> The reason being that a non-compiling test prevents
> at least 100 other tests from running.
>=20
> No files should be added to Insigth/Code under the
> pretext of supporting testing. Code freezing is in
> effect on the Insight/Code directory.
>=20
> Abtract classes must be tested by instantiating one
> of their concrete derived classes and exercising on
> them the functionalities provided by the abtract class.
>=20
> -------------- THE LIST -----------------------------
>=20
> ./=ADCode/=ADAlgorithms/=ADitkImageShapeModelEstimatorBase.h
> ./=ADCode/=ADAlgorithms/=ADitkBinaryMedialNodeMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkBinaryMedialNodeMetric.txx
> ./=ADCode/=ADAlgorithms/=ADitkMedialNodePairCorrespondenceProcess.h
> ./=ADCode/=ADAlgorithms/=ADitkMedialNodePairCorrespondenceProcess.txx
> ./=ADCode/=ADAlgorithms/=ADitkMedialNodeTripletCorrespondenceProcess.h
> ./=ADCode/=ADAlgorithms/=ADitkMedialNodeTripletCorrespondenceProcess.txx
> ./=ADCode/=ADAlgorithms/=ADitkNarrowBandThresholdSegmentationLevelSetImag=
eFilter.h
> ./=ADCode/=ADAlgorithms/=ADitkNarrowBandThresholdSegmentationLevelSetImag=
eFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkImageToMeshFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkGrayscaleFunctionDilateImageFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkGrayscaleFunctionErodeImageFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkExtractOrthogonalSwath2DImageFilter.txx
> ./=ADCode/=ADCommon/=ADitkBloxBoundaryProfileItem.h
> ./=ADCode/=ADCommon/=ADitkBloxBoundaryProfileItem.txx
> ./=ADCode/=ADCommon/=ADitkBloxBoundaryProfilePixel.h
> ./=ADCode/=ADCommon/=ADitkBloxBoundaryProfilePixel.txx
> ./=ADCode/=ADCommon/=ADitkConceptChecking.h
> ./=ADCode/=ADCommon/=ADitkConditionalConstIterator.h
> ./=ADCode/=ADCommon/=ADitkDecisionRuleBase.h
> ./=ADCode/=ADCommon/=ADitkDynamicLoader.cxx
> ./=ADCode/=ADCommon/=ADitkEventObject.cxx
> ./=ADCode/=ADCommon/=ADitkMetaDataObjectBase.h
> ./=ADCode/=ADCommon/=ADitkInPlaceImageFilter.h
> ./=ADCode/=ADCommon/=ADitkImageRegionReverseIterator.h
> ./=ADCode/=ADCommon/=ADitkInteriorExteriorSpatialFunction.h
> ./=ADCode/=ADCommon/=ADitkSmartPointerForwardReference.h
> ./=ADCode/=ADCommon/=ADitkSpatialFunction.h
> ./=ADCode/=ADCommon/=ADitkThinPlateR2LogRSplineKernelTransform.txx
> ./=ADCode/=ADCommon/=ADitkVolumeSplineKernelTransform.txx
> ./=ADCode/=ADCommon/=ADitkFiniteDifferenceSparseImageFunction.txx
> ./=ADCode/=ADCommon/=ADitkCorrespondenceDataStructure.h
> ./=ADCode/=ADCommon/=ADitkCorrespondenceDataStructure.txx
> ./=ADCode/=ADCommon/=ADitkCorrespondingList.h
> ./=ADCode/=ADCommon/=ADitkCorrespondingList.txx
> ./=ADCode/=ADCommon/=ADitkCorrespondingMedialNodeClique.h
> ./=ADCode/=ADCommon/=ADitkCorrespondingMedialNodeClique.txx
> ./=ADCode/=ADCommon/=ADitkNodeList.txx
> ./=ADCode/=ADCommon/=ADitkSecondaryNodeList.h
> ./=ADCode/=ADCommon/=ADitkSecondaryNodeList.txx
> ./=ADCode/=ADIO/=ADitkVOLImageIOFactory.cxx
> ./=ADCode/=ADIO/=ADitkVOLImageIOFactory.h
> ./=ADCode/=ADIO/=ADitkIOCommon.cxx
> ./=ADCode/=ADIO/=ADitkIPLCommonImageIO.h
> ./=ADCode/=ADIO/=ADitkRegularExpressionSeriesFileNames.cxx
> ./=ADCode/=ADIO/=ADitkRegularExpressionSeriesFileNames.h
> ./=ADCode/=ADNumerics/=ADitkSingleValuedNonLinearVnlOptimizer.h
> ./=ADUtilities/=ADkwsys/=ADRegularExpression.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DC0QuadraticTriangular.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DC0QuadraticTriangular.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DMembrane.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DMembrane.txx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement3DMembrane.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement3DMembrane.txx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMException.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMException.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMGenerateMesh.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMImageMetricLoad.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMImageMetricLoad.txx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMImageMetricLoadImplementation.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMLoadImplementationGenericLandmarkLo=
ad.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMLoadImplementationGenericLandmarkLo=
ad.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMSolverCrankNicolson.cxx
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMSolverCrankNicolson.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DStrain.h
> ./=ADCode/=ADNumerics/=ADFEM/=ADitkFEMElement2DStrain.txx
> ./=ADCode/=ADNumerics/=ADStatistics/=ADitkDecisionRuleBase.h
> ./=ADCode/=ADAlgorithms/=ADitkBioGeneNetwork.h
> ./=ADCode/=ADAlgorithms/=ADitkImageMomentsCalculator.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquaresPointSetToImageMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquaresPointSetToImageMetric.txx
> ./=ADCode/=ADAlgorithms/=ADitkMultiResolutionImagePyramid.txx
> ./=ADCode/=ADAlgorithms/=ADitkRayCastInterpolateImageFunction.txx
> ./=ADCode/=ADAlgorithms/=ADitkRegistrationMethod.h
> ./=ADCode/=ADAlgorithms/=ADitkRegistrationMethod.txx
> ./=ADCode/=ADAlgorithms/=ADitkVoronoiSegmentationRGBImageFilter.h
> ./=ADCode/=ADAlgorithms/=ADitkVoronoiSegmentationRGBImageFilter.txx
> ./=ADCode/=ADAlgorithms/=ADitkRayCastInterpolateImageFunction.h
> ./=ADCode/=ADAlgorithms/=ADitkUnsharpMaskLevelSetImageFilter.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanReciprocalSquareDifferencePointSetToIma=
geMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanReciprocalSquareDifferencePointSetToIma=
geMetric.txx
> ./=ADCode/=ADAlgorithms/=ADitkAnisotropicFourthOrderLevelSetImageFilter.h
> ./=ADCode/=ADAlgorithms/=ADitkAnisotropicFourthOrderLevelSetImageFilter.t=
xx
> ./=ADCode/=ADAlgorithms/=ADitkIsotropicFourthOrderLevelSetImageFilter.h
> ./=ADCode/=ADAlgorithms/=ADitkIsotropicFourthOrderLevelSetImageFilter.txx
> ./=ADCode/=ADAlgorithms/=ADitkUnsharpMaskLevelSetImageFilter.txx
> ./=ADCode/=ADAlgorithms/=ADitkCorrelationCoefficientHistogramImageToImage=
Metric.h
> ./=ADCode/=ADAlgorithms/=ADitkCorrelationCoefficientHistogramImageToImage=
Metric.txx
> ./=ADCode/=ADAlgorithms/=ADitkFEMFiniteDifferenceFunctionLoad.h
> ./=ADCode/=ADAlgorithms/=ADitkFEMFiniteDifferenceFunctionLoad.txx
> ./=ADCode/=ADAlgorithms/=ADitkHistogramImageToImageMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkHistogramImageToImageMetric.txx
> ./=ADCode/=ADAlgorithms/=ADitkMIRegistrationFunction.h
> ./=ADCode/=ADAlgorithms/=ADitkMIRegistrationFunction.txx
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquareRegistrationFunction.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquareRegistrationFunction.txx
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquaresHistogramImageToImageMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkMeanSquaresHistogramImageToImageMetric.txx
> ./=ADCode/=ADAlgorithms/=ADitkNCCRegistrationFunction.h
> ./=ADCode/=ADAlgorithms/=ADitkMutualInformationHistogramImageToImageMetri=
c.h
> ./=ADCode/=ADAlgorithms/=ADitkMutualInformationHistogramImageToImageMetri=
c.txx
> ./=ADCode/=ADAlgorithms/=ADitkNCCRegistrationFunction.txx
> ./=ADCode/=ADAlgorithms/=ADitkNormalizedMutualInformationHistogramImageTo=
ImageMetric.h
> ./=ADCode/=ADAlgorithms/=ADitkNormalizedMutualInformationHistogramImageTo=
ImageMetric.txx
> ./=ADCode/=ADBasicFilters/=ADitkNonThreadedShrinkImageFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkNonThreadedShrinkImageFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkParametricSpaceToImageSpaceMeshFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkParametricSpaceToImageSpaceMeshFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkChainCodeToFourierSeriesPathFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkChainCodeToFourierSeriesPathFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkGetAverageSliceImageFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkGetAverageSliceImageFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkLazyEdgeDetectionImageFilter3D.h
> ./=ADCode/=ADBasicFilters/=ADitkLazyEdgeDetectionImageFilter3D.txx
> ./=ADCode/=ADBasicFilters/=ADitkMidsagittalPlaneExtractionImageFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkMidsagittalPlaneExtractionImageFilter.txx
> ./=ADCode/=ADBasicFilters/=ADitkParallelSparseFieldLevelSetImageFilter.h
> ./=ADCode/=ADBasicFilters/=ADitkParallelSparseFieldLevelSetImageFilter.tx=
x
> ./=ADCode/=ADCommon/=ADitkBloxBoundaryPointPixel.h
> ./=ADCode/=ADCommon/=ADitkBloxItem.h
> ./=ADCode/=ADCommon/=ADitkConditionalIterator.h
> ./=ADCode/=ADCommon/=ADitkConditionalIterator.txx
> ./=ADCode/=ADCommon/=ADitkDefaultDynamicMeshTraits.h
> ./=ADCode/=ADCommon/=ADitkDefaultImageTraits.h
> ./=ADCode/=ADCommon/=ADitkDefaultStaticMeshTraits.h
> ./=ADCode/=ADCommon/=ADitkFiniteDifferenceFunction.txx
> ./=ADCode/=ADCommon/=ADitkFloodFilledFunctionConditionalIterator.h
> ./=ADCode/=ADCommon/=ADitkFloodFilledFunctionConditionalIterator.txx
> ./=ADCode/=ADCommon/=ADitkFloodFilledImageFunctionConditionalIterator.txx
> ./=ADCode/=ADCommon/=ADitkFloodFilledSpatialFunctionConditionalIterator.t=
xx
> ./=ADCode/=ADCommon/=ADitkHexahedronCellTopology.h
> ./=ADCode/=ADCommon/=ADitkImageContainerInterface.h
> ./=ADCode/=ADCommon/=ADitkImageIteratorWithIndex.h
> ./=ADCode/=ADCommon/=ADitkImageIteratorWithIndex.txx
> ./=ADCode/=ADCommon/=ADitkImageRandomIteratorWithIndex.h
> ./=ADCode/=ADCommon/=ADitkImageReverseIterator.h
> ./=ADCode/=ADCommon/=ADitkImageReverseIterator.txx
> ./=ADCode/=ADCommon/=ADitkIndexedContainerInterface.h
> ./=ADCode/=ADCommon/=ADitkIntTypes.h
> ./=ADCode/=ADCommon/=ADitkMeshRegion.cxx
> ./=ADCode/=ADCommon/=ADitkMeshRegion.h
> ./=ADCode/=ADCommon/=ADitkNeighborhoodAlgorithm.h
> ./=ADCode/=ADCommon/=ADitkNumericTraits.cxx
> ./=ADCode/=ADCommon/=ADitkPixelAccessor.h
> ./=ADCode/=ADCommon/=ADitkPixelTraits.h
> ./=ADCode/=ADCommon/=ADitkQuadraticTriangleCellTopology.h
> ./=ADCode/=ADCommon/=ADitkQuadrilateralCellTopology.h
> ./=ADCode/=ADCommon/=ADitkScalarVector.h
> ./=ADCode/=ADCommon/=ADitkSimpleFastMutexLock.h
> ./=ADCode/=ADCommon/=ADitkTetrahedronCellTopology.h
> ./=ADCode/=ADCommon/=ADitkTimeProbe.h
> ./=ADCode/=ADCommon/=ADitkTimeProbesCollectorBase.h
>=20
>=20
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk . org
> http://www . itk . org/mailman/listinfo/insight-developers
>=20