[Insight-developers] RE: DicomParser missing termination character

[Miller, James V (Research)]

Julien, 

I see you put in the fixes to the ITK repository. Good.  We'll move them to 
other repository later.

I noticed that the these character strings are set in the AppHelper as fixed

length character arrays.  I think you and Luis added these. I haven't looked

to see if DICOM has a limit on the length of a string.  Would we be better 
off using std::string for these variables instead of character strings?

Jim


-----Original Message-----
From: Julien Jomier [mailto:jjomier at cs.unc.edu]
Sent: Friday, August 27, 2004 3:22 PM
To: 'Insight Developers'
Cc: 'Miller, James V (Research)'
Subject: DicomParser missing termination character


Hello,

I've fixed (on my local copy) several problems in DicomParser resulting of
missing termination character in strings.
(This was reported about one week ago by Simon Harris on the users list).
Also I noticed that for each string the array of char is allocated but not
initialized, therefore garbage is returned if the DICOM tag is not found but
the user asks for the value of the tag.

I know that DicomParser has a separate CVS repository. Is DicomParser in ITK
in sync with the other repository?
Can I put the fixes in the Insight repository?

Thanks,

Julien