[Insight-developers] Re: ComputeNormal : itk::SimplexMesh]

[Leila Baghdadi]

Hello Master Luis,

Ok I have made the modifications, not much for Insight just two classes.

I still have to check InsightApplications,

Just wondering if the coast is clear for committing stuff to cvs
tomorrow morning, 

I thought there was some kind of cvs cleaning procedure going on!!

Leila

On Wed, 2007-24-01 at 12:08 -0500, Luis Ibanez wrote:
> Hi Leila,
> 
> Thanks for voluntering !  :-)
> 
> Thomas agree with the change,
> (see attached email)
> 
> The modification should have small impact.
> 
> Note that you may have to retouch InsightApplications,
> in particular your DeformableSurfaces application.
> 
> 
>    Thanks
> 
> 
>      Luis
> 
> 
> email message attachment (Re: [Insight-developers] ComputeNormal :
> itk::SimplexMesh)
> > -------- Forwarded Message --------
> > From: Thomas Boettger <tboettger at googlemail.com>
> > Reply-To: tboettger at gmail.com
> > To: Luis Ibanez <luis.ibanez at kitware.com>
> > Subject: Re: [Insight-developers] ComputeNormal : itk::SimplexMesh
> > Date: Wed, 24 Jan 2007 17:18:17 +0100
> > 
> > Dear Luis,
> > 
> > good point. I cannot remember why I chose to represent the normal as
> > a PointType. Today it looks stupid to me. I agree with you and you
> > should change it to vector. Furthermore I do think only
> > itkSimplexMeshAdaptTopologyFilter makes currently use of this method
> > when new points are inserted into the mesh. I think there should not
> > be any major changes. 
> > 
> > 
> > Please let me know if you have any further questions.
> > 
> > 
> >   Best,
> > 
> >     Thomas
> > 
> >  
> > 
> > On 1/24/07, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> >         
> >         Hi Thomas,
> >         
> >         
> >         Why is the "ComputeNormal()" method of the
> >         itkSimplexMesh returning a PointType ?
> >         
> >         http://www.itk.org/Insight/Doxygen/html/classitk_1_1SimplexMesh.html#itk_1_1SimplexMesha5
> >         
> >         A Normal should be returned as a CovariantVector,
> >         in order to be consistent under AffineTransforms.
> >         
> >         
> >         I would suggest we change the return type. 
> >         
> >         
> >         
> >         Please let us know,
> >         
> >         
> >              Thanks
> >         
> >         
> >                 Luis
> >         
> >         
> >         _______________________________________________
> >         Insight-developers mailing list
> >         Insight-developers at itk.org
> >         http://www.itk.org/mailman/listinfo/insight-developers
> >