[Insight-developers] RegressionTestImage in itkTestMain.h not checking image metadata

Tom Vercauteren tom.vercauteren at m4x.org
Thu Apr 30 10:34:51 EDT 2009


Hi all,

I just realized that the code used to compare images within the unit
tests does not check whether the images share the same spacing, origin
and direction.
  http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkTestMain.h?root=Insight&sortby=date&view=markup
It seems to me that this metadata should be checked.

A very similar problems happens with the ImageCompare utility that
comes with the insight journal submission template.
  http://public.kitware.com/pub/itk/InsightJournal/InsightJournalSubmissionTemplate.tgz
  http://public.kitware.com/pub/itk/InsightJournal/InsightJournalSubmissionTemplate.zip
  http://www.insight-journal.org/documentation/CMake/ImageCompare.tgz

Also it looks like there is a typo in a documentation of this
regression testing:
  http://www.vtk.org/Wiki/ITK_Procedure_for_Adding_a_Test#Adding_regression_Testing
In "compareNumberOfPixelsTolerance defines a Manhattan-type
neighborhood around a pixel [...]" shouldn't
compareNumberOfPixelsTolerance be replaced by compareRadiusTolerance?

Regards,
Tom


More information about the Insight-developers mailing list