[Insight-developers] Optimized ImageToImageMetric::SetFixedImageRegion signature

[Bradley Lowekamp]

Thank you Stephen for what should have been a rather obvious  
clarification.

On Aug 19, 2009, at 11:28 AM, Tom Vercauteren wrote:
>
> I agree but this basically implies changing itkSetMacro to use a const
> reference. This will change the public API of all ITK classes. This is
> not backward compatible as any user-defined derived class may now hide
> instead of override the functions defined by a itkSetMacro.
>
> For things in Review (as with the patch I applied), this is not a
> problem. But for ITK proper, we need to use the deprecation mechanism.
> I don't think it's worth changing itkSetMacro this in ITK 3.x. I'll
> add it the the ITK 4 wishlist.

I did not intend to suggest changing itkSetMacro. I intended to  
suggest an "itkSetConstReferenceMacro".

>
> For the second patch I am proposing, I think it's worth deprecating
> the volatile masks by using itkSetConstObjectMacro instead of
> itkSetObjectMacro because the volatile masks break const-corectness.
>
> Tom
>

========================================================
Bradley Lowekamp
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090819/512c4c95/attachment-0001.htm>