[Insight-developers] Warning in itkScalarConnectedComponentImageFilter

[Bill Lorensen]

Looks good. Do it.

On Fri, Jul 3, 2009 at 12:20 PM, Kevin H. Hobbs<hobbsk at ohiou.edu> wrote:
> When the itkScalarConnectedComponentImageFilter is instantiated with an
> int pixel type gcc produces a warning like the first one on the farsight
> dashboard here:
>
> http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=369974
>
> The line in question is :
>
> return (vnl_math_abs(a-b) <= m_Threshold);
>
> Stephen Aylward suggested on the farsight developers list here:
>
> http://www.kitware.com/cgi-bin/mailman/private/farsight-developers/2009-June/000113.html
>
> that this should be something like :
>
> TInput absDifference = static_cast<TInput>( vnl_math_abs( a-b ) );
> if( absDifference <= m_Threshold )
>  {
>  return true;
>  }
> else
>  {
>  return false;
>  }
>
> May I make this change?
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>