[Insight-developers] Disposal of ITK_USE_PORTABLE_ROUND

[Tom Vercauteren]

Thanks Luis. I just committed the patch and will track down potential
dashboard failures.

Tom

On Mon, Jun 15, 2009 at 21:28, Luis Ibanez<luis.ibanez at kitware.com> wrote:
>
> Hi Tom,
>
> The Experimental build came up green here.
>
> Please feel free to commit the patch at your convenience.
>
>
>  Thanks a lot for fixing this,
>
>
>
>     Luis
>
>
> -----------------
> Luis Ibanez wrote:
>>
>>
>> Hi Tom,
>>
>> This is a great time for making these changes.
>>
>> Thanks for sending the patch.
>>
>> I'm running an Experimental build with it,
>> I'll let you know how it goes.
>>
>> We probably should target for you to commit
>> the patch tomorrow morning, if that fits in your
>> schedule.
>>
>>
>>    Luis
>>
>>
>> --------------------------------------------------------
>> On Mon, Jun 15, 2009 at 9:49 AM, Tom Vercauteren
>> <tom.vercauteren at gmail.com <mailto:tom.vercauteren at gmail.com>> wrote:
>>
>>    Hi all,
>>
>>    As discussed prior to the 3.14 release, I'd like to remove the
>>    unnecessary ITK_USE_PORTABLE_ROUND cmake variable and add floor and
>>    ceil functions to the itk::Math namespace.
>>
>>    A proposed patch is attached. I have run two experimental builds. One
>>    on linux with centered pixels turned on:
>>    http://www.cdash.org/CDash/buildSummary.php?buildid=356248
>>    and one on mac (i686+ppc64) with centered pixels turned off:
>>    http://www.cdash.org/CDash/buildSummary.php?buildid=356212
>>
>>    The test failure I have on the mac looks really unrelated to my patch.
>>    The test failure I have on linux with centered pixels turned on seems
>>    related to an  outdated regression image.
>>
>>    Thoughts?
>>
>>    Best regards,
>>    Tom Vercauteren
>>
>>    _______________________________________________
>>    Powered by www.kitware.com <http://www.kitware.com>
>>
>>    Visit other Kitware open-source projects at
>>    http://www.kitware.com/opensource/opensource.html
>>
>>    Please keep messages on-topic and check the ITK FAQ at:
>>    http://www.itk.org/Wiki/ITK_FAQ
>>
>>    Follow this link to subscribe/unsubscribe:
>>    http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>