[Insight-developers] Please revert gdcmDocument.cxx?root=Insight&r1=1.32&r2=1.33 (for broken compiler)

[Luis Ibanez]

Hi Mathieu,

Thanks for pointing this out.

I'll keep it in mind as we go for the remaining 64bits to 32bits
conversion warnings.

Regarding the Borland builds,
they seem to be ok this morning.

Let us know if you still see reasons for reverting the changes.


    Thanks,


         Luis


-----------------------------------------------------------------------------------------------------
On Sun, Nov 22, 2009 at 8:02 AM, Mathieu Malaterre
<mathieu.malaterre at gmail.com> wrote:
> Ok. I did check with the previous bug fix:
>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/Utilities/gdcm/src/gdcmDocument.cxx?root=Insight&r1=1.3&r2=1.4
>
>  And as long as one cast to long just before <= operation, I think we
> should be ok. Let's see how the borland build test suite will act.
>
> Thanks, sorry for being so nervous,
>
> On Sun, Nov 22, 2009 at 12:41 PM, Mathieu Malaterre
> <mathieu.malaterre at gmail.com> wrote:
>> Luis,
>>
>>  In order to support broken compiler such as the Borland 5.5, one
>> should not use std::streampos. This has been found to be a bug (Thanks
>> to Bill Hoffman) in the header of borland, ref:
>>
>> http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-November/000912.html
>>
>>  Could you please revert
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Utilities/gdcm/src/gdcmDocument.cxx?root=Insight&r1=1.32&r2=1.33
>>
>> Thanks,
>> --
>> Mathieu
>>
>
>
>
> --
> Mathieu
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>