[Insight-developers] Git Hub of queued up ITK changes

Bradley Lowekamp blowekamp at mail.nih.gov
Sun Aug 1 10:38:43 EDT 2010


Hans,

Just to be clear both of these defines are needed only for the Borland/VS6 compiler if I recall correctly. All other compilers we had on the dashboard, had a 64-bit integer. I just want to make sure that this issue is separate from the windows long!=int64_t issue. These flags are now dead code that is not utilized by any compiler we support.

Is there a place for me to log this type of issue? Mantis? Or is the a some other list of things that need to be done/re-factor/removed?

Brad

On Jul 29, 2010, at 9:19 PM, Hans Johnson wrote:

> Brad,
> 
> The changes I made did not attempt to address the 64-bit integer or long long issues.
> 
> I’ve simply removed dead code that was never compiled if some of the non-default Cmake ITK_LEGACY_REMOVE options were turned off.
> 
> The 64bit integer situation still needs to be addressed.
> 
> Hans
> 
> 
> 
> On 7/29/10 4:56 PM, "Bradley Lowekamp" <blowekamp at mail.nih.gov> wrote:
> 
>> Hello Hans,
>> 
>> Are we going to require that the systems have a functioning 64-bit integer and type long long?
>> 
>> I just quickly looked through your changes. There are many so hopefully I didn't miss this one. The related defines are ITK_HAS_INT_64 and ITK_TYPE_USE_LONG_LONG. They spread from itkIntType.h and itkConfigure.h.in.
>> 
>> Brad
>> 
>> 
>> On Jul 29, 2010, at 11:39 AM, Hans Johnson wrote:
>> 
>>> There was a request to hold off on committing to the ITKv4 tree while the dashboard systems are updated to deal with git.
>>> 
>>> In order to keep moving forward on some of the ITKv4 roadmap issues, forked a private gitHub repository from kitware/ITK gitHub repository, and posted my recent patch changes there.
>>> 
>>> http://github.com/hjmjohnson/ITK/tree/ITK_LEGACY_REMOVE
>>> 
>>> 
> 
> -- 
> Hans J. Johnson, Ph.D.
> Assistant Professor
> 200 Hawkins Drive
> T205 BT, The University of Iowa
> Iowa City, IA 52242
> 
> hans-johnson at uiowa.edu
> PHONE: 319 353 8587

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100801/377db6e5/attachment.htm>


More information about the Insight-developers mailing list