[Insight-developers] adding authors to Gerrit reviewers

Bill Lorensen bill.lorensen at gmail.com
Sun Nov 14 13:58:09 EST 2010


Luis,

For example, you and I have probably touched every file in itk. Do you
want to be a reviewer on every gerrit topic? Brad L. and Hans also.

Bill

On Sun, Nov 14, 2010 at 1:38 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> I don't think it should be a hook. It adds a lot of reviewers (I
> think) and reviewers can be overwhelmed with these auto generated
> reviewer lists.
>
> On Sun, Nov 14, 2010 at 1:12 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>
>> Matt,
>>
>> This looks great !
>>
>> Marcus:
>>
>> Do you see any reason for not adding this scripts
>> to the directory:
>>
>>      ITK/Utilities/DevelopmentSetupScripts
>>
>>
>> or even to make this an automatic hook ?
>>
>>
>>    Thanks
>>
>>
>>         Luis
>>
>>
>>
>> --------------------------------------------------------------
>> On Fri, Nov 12, 2010 at 8:58 AM, Matthew McCormick (thewtex)
>> <matt at mmmccormick.com> wrote:
>>>
>>> Hi,
>>>
>>> I scraped together a simple script to automate selection and
>>> submission of Gerrit reviewers.  Here is a link in case anyone else
>>> may find it useful:
>>> https://gist.github.com/674093
>>>
>>> Candidates are nominated from former authors of the edited files.
>>> People probably want to know when I am breaking ... I mean, fixing ;-)
>>> .. their files, and they are probably the most knowledgeable
>>> individuals of the issues at hand.  It saves having to pick out
>>> reviewers manually and the need to re-enter reviewers for every commit
>>> on a long topic branch.
>>>
>>> It has rudimentary user interactivity, but more could be done with it.
>>>  I don't have time to rigorously fix it up, but if someone is
>>> interested, go for it.
>>>
>>> To use it, run it instead of 'git gerrit-push' on the initial push to
>>> Gerrit.
>>>
>>> Matt
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>


More information about the Insight-developers mailing list