[Insight-developers] add_reviewers.py

[Matthew McCormick (thewtex)]

Hi Bill and modular ITKers,

I was able to reproduce the same error using Python 2.6.  I have
updated the script at the same address
https://gist.github.com/674093/
and checked to make sure it works on Python 2.4, 2.5, 2.6, 2.7, and 3.1.

I also sorted by a count of lines changed over the past 5 years as
suggested at the tcon.  Only those with a line count greater than zero
are set to 'on' by default.

Although this is probably not the only application, it brings up the
importance of keeping the change history when moving to the
modularization I read about on the wiki.  Brad King did a nice job of
retaining the Testing/Data history in its submodule.  Are we going to
have the same for modular-ITK?

Matt

On Tue, Nov 16, 2010 at 3:30 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Matt,
>
> I tried the script today and reveived this error:
>  ~/Downloads/gist674093-c12b02d7e76131b1eb1d70ae8215f75687491faa/add-reviewers.py
>
> Traceback (most recent call last):
>  File "/home/lorensen/Downloads/gist674093-c12b02d7e76131b1eb1d70ae8215f75687491faa/add-reviewers.py",
> line 83, in <module>
>    reviewers, request_review = select_reviewers( reviewers, request_review )
>  File "/home/lorensen/Downloads/gist674093-c12b02d7e76131b1eb1d70ae8215f75687491faa/add-reviewers.py",
> line 52, in select_reviewers
>    print_potential_reviewers( reviewers, request_review )
>  File "/home/lorensen/Downloads/gist674093-c12b02d7e76131b1eb1d70ae8215f75687491faa/add-reviewers.py",
> line 45, in print_potential_reviewers
>    print( '{} [{:2}] {}  \t<{}>'.format( will_review, i, r[0], r[1] ) )
> ValueError: zero length field name in format
>
> Bill
>