[Insight-developers] Commit message prefix hook. Why was this pushaccepted?

Bill Lorensen bill.lorensen at gmail.com
Sun Nov 28 13:57:35 EST 2010


But shouldn't the merge be refused? I guess I don't understand how the
commit hooks work.


On Sun, Nov 28, 2010 at 12:50 PM, Hans Johnson <hans-johnson at uiowa.edu> wrote:
> Much of this happed because this patch-set was dormant for two weeks.  The
> commit message prefix hooks were added after the patch-set was submitted to
> Gerrit.
>
> Hans
>
>
> On 11/28/10 11:28 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>
>> Folks,
>>
>> This gerrit topic:
>> http://review.source.kitware.com/#change,355
>> was successfully merged.
>>
>> Yet, it's commit message prefix does not conform to the ITK convention.
>>
>> How did this happen?
>>
>> Also since this adds a new base capability to ITK, 13 reviewers were
>> requested, yet only 5 reviewers responded, and onl;y 2 approved.
>>
>> Bill
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
> --
> Hans J. Johnson, Ph.D.
> Assistant Professor
> 200 Hawkins Drive
> T205 BT, The University of Iowa
> Iowa City, IA 52242
>
> hans-johnson at uiowa.edu
> PHONE: 319 353 8587
>
>


More information about the Insight-developers mailing list