[Insight-developers] Potential erroneous change made by uncrustify

Brad King brad.king at kitware.com
Tue Oct 5 13:47:36 EDT 2010


On 10/05/2010 11:35 AM, Bradley Lowekamp wrote:
> It appears the following change may have occurred due to uncrustify. Any
> commit of an uncrustify configuration file should be verified that these
> files do no regress. 
> 
> There is some info in the review here:
> http://review.source.kitware.com/#change,65
> 
> Relavent commit history:
> http://itk.org/gitweb?p=ITK.git;a=commitdiff;h=50bdfb1fb8fe53ce231bb009aaaa57846fd3e4f0
> http://itk.org/gitweb?p=ITK.git;a=history;f=Code/Review/itkVTKImageIO2.cxx;h=d2cf9ed0bb9b1de4b19e217289ca9863998e6697;hb=HEAD

I just ran

 $ uncrustify -c Utilities/Maintenance/uncrustify_itk.cfg -f Code/Review/itkVTKImageIO2.cxx

with ITK commit b55c3a598 checked out in my work tree.  It did not change
the string literal.

I merged Matt M's topic:

  http://itk.org/gitweb?p=ITK.git;a=commitdiff;h=a26714bd

to add the style helper hooks and close the Gerrit entries.  The hooks
will be enabled only by explicit request (running Utilities/hooks.sh
or by hand).

-Brad K


More information about the Insight-developers mailing list