[Insight-developers] ITK / Gerrit question

[Bill Lorensen]

Marcus,

Some of us are doing multiple reviews at the same time. And some of us
always make a branch when we are reviewing.

Also, a branch is useful if you are going to push another user's
gerrit patch to the stage.

Right now, I manually do a git checkout -b topic_name and I cut the
topic name from the gerrit page so that I don't misspell it.

I would find this very useful.

Bill

On Tue, Oct 26, 2010 at 1:21 PM, Marcus D. Hanwell
<marcus.hanwell at kitware.com> wrote:
> On Tue, Oct 26, 2010 at 11:40 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>
>> Hi Marcus,
>>
>> At the ITK tcon we were wondering if we could modify our installation of
>> Gerrit
>> to have the git command line create a branch with the topic that is just
>> checked out.
>>
>> so, to change:
>>
>> git fetch ssh://ibanez@review.source.kitware.com:29418/ITK
>> refs/changes/34/234/1
>> && git checkout FETCH_HEAD
>>
>> into
>>
>>
>> git fetch ssh://ibanez@review.source.kitware.com:29418/ITK
>> refs/changes/34/234/1
>> && git checkout FETCH_HEAD -b topic-name
>>
>>
>> Do you think this could be done ?
>>
> I think it could be done, but the majority of the time when reviewing
> a topic branch there is no need to make it into a named topic branch.
> You only really need to assign it a name if you are going to stage it,
> and merge it. Then a,
>
> git checkout -b topic-name
>
> Would give you that from the detached head. You still need to ensure
> you are at the tip of the topic, and most of the time I would rather
> have the current behavior. I can take a look and see where the change
> would be required, and how likely it is that it would be accepted
> upstream (as we would rather not maintain a patched version of Gerrit
> long term).
>
> Marcus
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>