[Insight-developers] Problem while changing core ITK classes.

[Antonin Perrot-Audet]

The first change was posted on gerrit, but with the non modular ITK : it 
is removing one useless norm computation (per evaluation) in the 
ConicShellSpacialFunction,
As ITK went modular before the patch was reviewed, I am rebasing it on 
the new modular ITK.

I also modified the GaussianImageSource for multithreading,
I also modified the EigenAnalysis2DImageFilter for removing the 
unnecessary GetPointer, that you pointed out (as it is the reference 
class for multiple outputs, I though it should be exemplary).

Those are minor modifications, I plan on contributing more if it is easy 
enough to do so.
I also created algorithms, but I think that if they are to be integrated 
to ITK at some point, their place is more in the insight journal ?

Regards,

Antonin


On 4/4/11 4:20 PM, Luis Ibanez wrote:
> Antonin,
>
> Please don't reuse subjects from other emails,
> for introducing new topics.
>
> Your email is unrelated to the email that you
> are replaying to.
>
>
> Please see more comments below.
>
>
> On Mon, Apr 4, 2011 at 10:06 AM, Antonin Perrot-Audet
> <antonin07130 at gmail.com>  wrote:
>> Modules and ITK test compilation
>>
>> Hello, I was trying to compile the new modularized itk. I did some changes
>> in some classes of core, and wanted to compile only the core module, with
>> its tests and examples.
>>
>> But it seems like *Core module examples depends on the Segmentation module*
>> : for instance, for the NeighborhoodIterators6
>>
> You can trace the dependencies by looking at the files "itk-module.cmake"
> at the top level directory of every module.
>
>
>> Scanning dependencies of target NeighborhoodIterators6
>> [ 89%] Building CXX object
>> Examples/Iterators/CMakeFiles/NeighborhoodIterators6.dir/NeighborhoodIterators6.cxx.o
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:26:40:
>> error: itkFastMarchingImageFilter.h: No such file or directory
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx: In
>> function ‘int main(int, char**)’:
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:70:
>> error: expected initializer before ‘<’ token
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:72:
>> error: ‘FastMarchingFilterType’ has not been declared
>>
>> [...]
>
> NeighborhoodIterators6 is an Example.
>
> Examples depend on all the modules.
>
>
>
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:91:
>> error: ‘node’ was not declared in this scope
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:93:
>> error: ‘seeds’ was not declared in this scope
>> /Users/antonin/GITROOT/ITK/Examples/Iterators/NeighborhoodIterators6.cxx:96:
>> error: ‘fastMarching’ was not declared in this scope
>>
>> What should be done ? move this example to the Segmentation Module ?
>>
>
> Let's start at the beginning...
>
> Can you please describe first the changes that you are trying to make ?
>
> and what their purpose is ?
>
>
>      Thanks
>
>
>           Luis
>
>
>
>
>> --
>> Antonin Perrot-Audet
>> Electrical Engineering&    Computer Sciences, INSA Lyon
>> M2 GEGP Signal&    Image Processing, INSA Lyon, UCBL, Centrale Lyon
>>
>> _______________________________________________


-- 
Antonin Perrot-Audet
Electrical Engineering&  Computer Sciences, INSA Lyon
M2 GEGP Signal&  Image Processing, INSA Lyon, UCBL, Centrale Lyon