[Insight-developers] Change some CMake option names to reduce global CMake namespace pollution?

Gaëtan Lehmann gaetan.lehmann at jouy.inra.fr
Tue Apr 19 15:28:19 EDT 2011


Please don't change the option name now.

I also agree that USE_WRAP_ITK is not good enough. But I'd like to  
activate the wrapping by choosing the target language directly,  
without the need for a ITK_USE_WRAPPING or USE_WRAP_ITK.

Thanks,

Gaëtan


Le 19 avr. 11 à 19:04, Bill Lorensen a écrit :

> I agree also, especially since the cmake-gui nicely groups things if
> they have a common prefix.
>
>
> On Tue, Apr 19, 2011 at 12:59 PM, Johnson, Hans J
> <hans-johnson at uiowa.edu> wrote:
>> Kent,
>>
>> I agree with this for ITKv4.
>>
>> I would recommend that the last item change to
>> ITK_USE_WRAPPING
>>
>> Please propose a gerrit patch that includes a migration guide  
>> document.
>>
>> Hans
>> --
>> Hans J. Johnson, Ph.D.
>> hans-johnson at uiowa.edu
>> Assistant Professor of Psychiatry
>> University of Iowa Carver College of Medicine
>> W278 GH, 200 Hawkins Drive
>>
>> Iowa City, Iowa 52242
>> Phone:  319-353-8587
>>
>>
>>
>>
>>
>>
>>
>> -----Original Message-----
>> From: Kent Williams <norman-k-williams at uiowa.edu>
>> Date: Tue, 19 Apr 2011 15:00:17 +0000
>> To: ITK <insight-developers at itk.org>
>> Subject: [Insight-developers] Change some CMake option names to  
>> reduce
>> global CMake namespace pollution?
>>
>> Right now there are 4 variables -- specific to ITK -- that begin  
>> with USE
>> instead of ITK:
>>
>>
>> USE_FFTWD
>> USE_FFTWF
>> USE_SYSTEM_FFTW
>> USE_WRAP_ITK
>>
>> Shouldn't these all be changed to, e.g.
>>
>> ITK_USE_FFTWD
>> ITK_USE_FFTWF
>> ITK_USE_SYSTEM_FFTW
>> ITK_USE_WRAP_ITK
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is  
>> covered by
>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>> confidential and may be legally privileged.  If you are not the  
>> intended
>> recipient, you are hereby notified that any retention, dissemination,
>> distribution, or copying of this communication is strictly  
>> prohibited.
>> Please reply to the sender that you have received the message in  
>> error,
>> then delete it.  Thank you.
>> ________________________________
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is  
>> covered by the Electronic Communications Privacy Act, 18 U.S.C.  
>> 2510-2521, is confidential and may be legally privileged.  If you  
>> are not the intended recipient, you are hereby notified that any  
>> retention, dissemination, distribution, or copying of this  
>> communication is strictly prohibited.  Please reply to the sender  
>> that you have received the message in error, then delete it.  Thank  
>> you.
>> ________________________________
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110419/7a6ace74/attachment.pgp>


More information about the Insight-developers mailing list