[Insight-developers] Moving ChanAndVese out of Review ?

[Luis Ibanez]

Hi Arnaud,

The Gerrit patch is here:
 http://review.source.kitware.com/#change,1504


    Thanks

         Luis


---------------------------
On Mon, Apr 25, 2011 at 4:58 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> Arnaud,
>
> Excellent idea !!
>
> In that way we don't lose the example either.
>
> I'll prepare a Gerrit patch with those changes.
>
>
>    Thanks
>
>
>         Luis
>
>
> -------------------------
> On Mon, Apr 25, 2011 at 4:53 PM, Arnaud GELAS
> <arnaud_gelas at hms.harvard.edu> wrote:
>> Luis,
>>
>> We could first move this example in the wiki example. Like this,
>> people can access them and play with them, and it will force us
>> to correct the wiki example once these classes are refactored).
>>
>> Then it makes sense to the Examples/Review directory!!!
>>
>> Arnaud
>>
>> On 04/25/2011 04:48 PM, Luis Ibanez wrote:
>>>
>>> Hi Arnaud,
>>>
>>> Thanks for the feedback.
>>>
>>> How about then, we just remove the examples that are
>>> currently in:
>>>
>>>      ITK/Examples/Review/
>>>         itkScalarSinglePhaseDense2DTest.cxx
>>>         itkScalarSinglePhaseSparse2DTest.cxx
>>>
>>> They have not been integrated with the Software Guide,
>>> and if the API of the ShanAndVese classes change, then
>>> the examples would have to be reworked anyways...
>>>
>>>
>>> The only other dependency that Exampls has on Review,
>>> is due to the MemoryProbeCollectors, which I'm also planning
>>> to code review now, and move in to the Common Module.
>>>
>>>
>>>     Please let us know if removing
>>>     Examples/Review makes sense.
>>>
>>>
>>>          Luis
>>>
>>>
>>>
>>> --------------------------------------------------
>>> On Mon, Apr 25, 2011 at 3:05 PM, Arnaud GELAS
>>> <arnaud_gelas at hms.harvard.edu>  wrote:
>>>>
>>>> Luis,
>>>>
>>>> In short term, it makes sense to move this code out of the review
>>>> directory!
>>>>
>>>> However, we are in the process of refactoring the whole framework, and we
>>>> are in the process of drastically change the whole hierarchy. Note, as of
>>>> now we use Chan and Vese as first example to test, and validate our
>>>> development.
>>>>
>>>> So in the long term, I am not sure if it really makes sense to extract
>>>> all
>>>> these classes from the Review directory. But some of these classes will
>>>> be
>>>> used in the future version, and that's the reason why, I have been
>>>> submitting this patch to gerrit:
>>>>
>>>>    http://review.source.kitware.com/#change,1460
>>>>
>>>> If needed, we can discuss about it in an appropriate TConf.
>>>>
>>>> Thanks,
>>>> Arnaud
>>>>
>>>> On 04/25/2011 02:43 PM, Luis Ibanez wrote:
>>>>>
>>>>> Hi Kishore, Arnaud,
>>>>>
>>>>> As our initial work in the Code Review effort
>>>>> we are trying to clean up the dependencies
>>>>> on the Review directory.
>>>>>
>>>>> Currently one of them is the use of ChanAndVese
>>>>> filters in the Examples.
>>>>>
>>>>> We would like to do a full code review of the
>>>>> ChanAndVese classes and (once they pass the
>>>>> code review) move them out of the Review directory
>>>>> to put them in their final module in the toolkit
>>>>>
>>>>> Most likely the LevelSets modules...
>>>>>
>>>>> Would you have any concerns with
>>>>> us fixing and moving this code ?
>>>>>
>>>>> Were you anticipating any major refactoring
>>>>> of these classes ?
>>>>>
>>>>>
>>>>>     Thanks
>>>>>
>>>>>
>>>>>          Luis
>>>>
>>
>>
>