No subject

Hello David Cole,

I'd like you to do a code review.  Please visit

   http://review.source.kitware.com/1967

to review the following change.

Change subject: COMP: root of source and binary dir of ITK should not be too
deep.
......................................................................

COMP: root of source and binary dir of ITK should not be too deep.

Change-Id: I79013671626f70b869e5d4e11a7e1d8987dad2b9
---
M CMakeLists.txt
1 file changed, 23 insertions(+), 0 deletions(-)


 git pull ssh://review.source.kitware.com/ITK refs/changes/67/1967/1
--
To view, visit http://review.source.kitware.com/1967
To unsubscribe, visit http://review.source.kitware.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79013671626f70b869e5d4e11a7e1d8987dad2b9
Gerrit-PatchSet: 1
Gerrit-Project: ITK
Gerrit-Branch: master
Gerrit-Owner: Alex. Gouaillard <agouaillard at gmail.com>
Gerrit-Reviewer: David Cole <david.cole at kitware.com>

--bcaec53fedc32f377404a66509b6
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

This gerrit change proposes to limit the path length of both the source and=
 binary trees on Windows builds of ITK. Before we accept this change, is th=
ere anybody who has a reason why this would be a problem for them?<div><br>
</div><div>I think it&#39;s a reasonable compromise given the length of the=
 depth of the tree, and the problems that ensue. (When using certain versio=
ns of CMake and certain versions of Visual Studio, relative path names comb=
ined with the absolute path of the build tree, combine to exceed the 250-so=
mething character file name limit in some of the underlying Windows tools u=
sed...)</div>
<div><br></div><div>Raise objections now, if any, or forever hold your peac=
e. :-)</div><div><br></div><div><br></div><div>Thanks,</div><div>David C.</=
div><div><br><br><div class=3D"gmail_quote">---------- Forwarded message --=
--------<br>
From: <b class=3D"gmail_sendername">Code Review</b> <span dir=3D"ltr">&lt;<=
a href=3D"mailto:review at kitware.com">review at kitware.com</a>&gt;</span><br>D=
ate: Thu, Jun 23, 2011 at 12:07 PM<br>Subject: Change in ITK[master]: COMP:=
 root of source and binary dir of ITK should not be too...<br>
To: David Cole &lt;<a href=3D"mailto:david.cole at kitware.com">david.cole at kit=
ware.com</a>&gt;<br><br><br>From Alex. Gouaillard &lt;<a href=3D"mailto:ago=
uaillard at gmail.com">agouaillard at gmail.com</a>&gt;:<br>
<br>
Hello David Cole,<br>
<br>
I&#39;d like you to do a code review. =A0Please visit<br>
<br>
 =A0 =A0<a href=3D"http://review.source.kitware.com/1967" target=3D"_blank"=
>http://review.source.kitware.com/1967</a><br>
<br>
to review the following change.<br>
<br>
Change subject: COMP: root of source and binary dir of ITK should not be to=
o deep.<br>
......................................................................<br>
<br>
COMP: root of source and binary dir of ITK should not be too deep.<br>
<br>
Change-Id: I79013671626f70b869e5d4e11a7e1d8987dad2b9<br>
---<br>
M CMakeLists.txt<br>
1 file changed, 23 insertions(+), 0 deletions(-)<br>
<br>
<br>
 =A0git pull ssh://<a href=3D"http://review.source.kitware.com/ITK" target=
=3D"_blank">review.source.kitware.com/ITK</a> refs/changes/67/1967/1<br>
--<br>
To view, visit <a href=3D"http://review.source.kitware.com/1967" target=3D"=
_blank">http://review.source.kitware.com/1967</a><br>
To unsubscribe, visit <a href=3D"http://review.source.kitware.com/settings"=
 target=3D"_blank">http://review.source.kitware.com/settings</a><br>
<br>
Gerrit-MessageType: newchange<br>
Gerrit-Change-Id: I79013671626f70b869e5d4e11a7e1d8987dad2b9<br>
Gerrit-PatchSet: 1<br>
Gerrit-Project: ITK<br>
Gerrit-Branch: master<br>
Gerrit-Owner: Alex. Gouaillard &lt;<a href=3D"mailto:agouaillard at gmail.com"=
>agouaillard at gmail.com</a>&gt;<br>
Gerrit-Reviewer: David Cole &lt;<a href=3D"mailto:david.cole at kitware.com">d=
avid.cole at kitware.com</a>&gt;<br>
</div><br></div>

--bcaec53fedc32f377404a66509b6--