[Insight-developers] strange error with export list on modular ITK

[Steve Pieper]

Hi Alex -

I'm happy to help pass this on to the dcmtk guys - do we have a final patch
that includes Brad's suggestion about the install dirs too?

-Steve

On Mon, Dec 19, 2011 at 9:53 AM, Alexandre GOUAILLARD <agouaillard at gmail.com
> wrote:

> ok, good news and bad news,
>
> I like my dessert first: I fixed it. However it requires modification
> in DCMTK itself to make its targets exportable to an external
> "superbuild".
>
> steve, stephen, could you help me contact the DCMTK guys to transfer
> those changes (it should be backward compatible) ?
>
> On to the ImageIO itself now.
>
> diff --git a/CMake/KitCommonBlock.cmake b/CMake/KitCommonBlock.cmake
> index 72a500b..fd6c3f5 100644
> --- a/CMake/KitCommonBlock.cmake
> +++ b/CMake/KitCommonBlock.cmake
> @@ -4,7 +4,9 @@ ADD_LIBRARY(${KIT} STATIC ${Kit_SRCS} ${Kit_EXTRA_SRCS})
>  TARGET_LINK_LIBRARIES(${KIT} ${KIT_LIBS} ${KIT_EXTRA_LIBS})
>
>  INSTALL(TARGETS ${KIT}
> -  DESTINATION ${DCMTK_INSTALL_LIB_DIR} COMPONENT Development
> +  EXPORT ${DCMTK_TARGETS_NAME}
> +  DESTINATION ${DCMTK_INSTALL_LIB_DIR}
> +  COMPONENT Development
>   )
>
>  # End of common section
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 87326d8..b6008e8 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -14,6 +14,12 @@ SET(DCMTK_INSTALL_INCLUDE_DIR "include")
>  SET(DCMTK_INSTALL_LIB_DIR "lib")
>  SET(DCMTK_INSTALL_BIN_DIR "bin")
>
> +# to be able to "redirect" export
> +# to external projects that embbed DCMTK (ITK)
> +IF(NOT DCMTK_TARGETS_NAME)
> +  SET(DCMTK_TARGETS_NAME DCMTKTargets)
> +ENDIF(NOT DCMTK_TARGETS_NAME)
> +
>
>  #-----------------------------------------------------------------------------
>  # Output directories.
>  IF(NOT LIBRARY_OUTPUT_PATH)
> @@ -216,3 +222,4 @@ FOREACH(lib_include_subdir ${lib_include_subdirs})
>     DESTINATION
> ${DCMTK_INSTALL_INCLUDE_DIR}/dcmtk/${lib}/${lib_include_subdir}
> COMPONENT Development
>     )
>  ENDFOREACH()
>
>
> thanks in advance.
>
> alex.
>
> On Mon, Dec 19, 2011 at 7:12 PM, Alexandre GOUAILLARD
> <agouaillard at gmail.com> wrote:
> > hi guys,
> >
> > I m working on the latest integration of DCMTK in ITK as a module, and
> > I have some unseen before error:
> > CMake Error: INSTALL(EXPORT "ITKTargets" ...) includes target
> > "ITKIODCMTK" which requires target "oflog" that is not in the export
> > set.
> >
> > anybody has an idea of what i need to do to make it vanish?
> > I tried itk_module_target() with no success so far.
> >
> > the code is here (DCMTK branch):
> > https://github.com/ComplexSystemsModeling/DCMTK-ITK/tree/DCMTK
> >
> > thanks in advance.
> >
> > alex.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20111219/de9af655/attachment.htm>