[Insight-developers] Valgrind defect

Williams, Norman K norman-k-williams at uiowa.edu
Thu Jul 14 11:26:16 EDT 2011


One of the problems here is what I regard as a problem with a
SceneSpatialObject method:


ObjectListType *GetObjects(unsigned int depth = MaximumDepths, char *name
= NULL);

The problem is that it uses dynamic allocation to create an instance of
std::list< SpatialObject<Dimension>::Pointer >

If I ran the circus, I'd change it to

ObjectListType GetObjects(...);

The downside would be copying a list of smart pointers. The upside would
be NO MORE USER MANAGEMENT OF MEMORY ALLOCATION THAT IS INCONSISTENT WITH
95% OF ITK.

Thoughts? Is it worth breaking backwards compatibility to fix this?

On 7/14/11 6:28 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:

>Kent,
>
>This one has been around since you changed some Meta stuff (I think it
>was you).
>http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=2440091
>
>Can you take a look?
>
>Thanks,
>
>Bill



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________


More information about the Insight-developers mailing list