[Insight-developers] Dashboard woes

[Luis Ibanez]

Bill,

I have another patch almost ready.

    Luis


-----------------------------
On Thu, Jun 2, 2011 at 10:17 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> That said, we need to green-up the dashboard. My patch:
> http://review.source.kitware.com/#change,1774 fixes the dependency. I
> do not see a circular dependency.
>
> If the recent functor changes are backed out, then we can always
> revert the dependency in my patch.
>
> Bill
>
> On Thu, Jun 2, 2011 at 8:57 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> Bill,
>>
>> This is the consequence of an incomplete analysis
>> of dependencies when making changes.
>>
>> 1) The Changes in BinaryFunctorImageFilter
>>    introduced the use of the LinearInterpolator
>>    in a filter that up to now was quite self-sufficient.
>>
>> 2) BinaryFunctorImageFilter in in Core/Common
>>
>> 3) ITK-Common DEPENDS ITK-VNLInstantiation ITK-KWSys
>>     (only)
>>
>> 4) With the changes in BinaryFunctor, now Common
>>     depends (in practice) on the ITK-ImageFunctions module.
>>     because that's where the Interpolators are. But, the
>>     module dependency was not made explicit because...
>>
>> 5)  ITK-ImageFunction already depends on ITK-Common
>>
>> 6)  Ergo sum: Circular dependency
>>
>> 7) Why did this go unnoticed before ?
>>
>>     Because the test of the BinaryFunctor was made to
>>     depend on the ITK-ImageFunction module, giving
>>     the false impression that the problem was fixed.
>>
>> 8)  The recent relocation of the ImageCompose - related
>>      filters exposed the missing dependency between
>>      the BinaryFunctorImageFitler and the Interpolators.
>>
>> ---
>>
>> I would have to agree with Brad L. on that this change
>> in BinaryFunctorImageFilter is feature creep, and that
>> we should reconsider the usefulness of that change.
>>
>>
>>      Luis
>>
>>
>> --------------------
>> On Wed, Jun 1, 2011 at 11:55 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>> Folks,
>>>
>>> I suggest we hold off on any new merges except for those that will
>>> bring the Dashboard back to normalcy. There is no sense in checking in
>>> code when there are so many compile errors on so many platforms.
>>>
>>> Bill
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>
>