[Insight-developers] Commit problem

[Luis Ibanez]

Hi Hans,

We kind of have this already.

It is in fact, that commit hook the one that stopped
Ashish from continue working in that mis-configured
repository.

What we don't have is something that will prevent
a developer from:

  a) creating branches
  b) calling "git add"

before he/she has called the
SetupForDevelopment.sh script.

--

I guess, that there is a point where developers
may actually have to read the instructions and
follow them.


     Luis


---------------------------------------------------------------
On Wed, Jun 8, 2011 at 9:17 PM, Johnson, Hans J <hans-johnson at uiowa.edu> wrote:
> Luis,
>
> I wonder if we could set up some sort of sentinel file to ensure this.
>
> For example
> 1)  At the end of SetupForDevelopment.sh, write
> .ready_for_development_sentinal file in the untilites directory
> 2)  Setup a git to ignore .ready_for_development_sentinal
> 3)  Create a git commit hook that requires the file
> .ready_for_development_sentinal to exists
>
> Hans
>
>
> On 6/8/11 5:48 PM, "Luis Ibanez" <luis.ibanez at kitware.com> wrote:
>
>>Ashish,
>>
>>Thanks for you time on the phone today.
>>
>>--
>>
>>To summarize for the list,
>>Here is what we found:
>>
>>Ashish had a clone of ITK,
>>in which he didn't initially run the
>>SetupForDevelopment.sh script.
>>
>>He made changes in that cloned repository (created a branch,
>>and did "git add "s).  Then when committing the git hooks
>>indicated that the repository was not setup for commits.
>>
>>At that point he ran the SetupForDevelopment.sh script,
>>but it was too late for properly preparing the hooks in the
>>repository.
>>
>>In the same machine, we verified that in a newly cloned
>>repository, *and* running the SetupForDevelopment.sh script
>>just after cloning, the rest of the setup worked properly.
>>
>>
>>The take home message:
>>
>>When starting to work in an ITK Clone do:
>>
>>  A)   Clone the repository
>>
>>  B)   Right away,
>>         call the SetupForDevelopment.sh script
>>         (do not wait to do this later).
>>
>>
>>
>>    Luis
>>
>>
>>----------------------------------------
>>On Wed, Jun 8, 2011 at 10:56 AM, Luis Ibanez <luis.ibanez at kitware.com>
>>wrote:
>>> Hi Ashish,
>>>
>>> Off the list, please email me a phone number
>>> (or Skype Id) and I'll call you to track and
>>> fix this problem.
>>>
>>>
>>>    Thanks
>>>
>>>
>>>         Luis
>>>
>>>
>>> ------------------------------------
>>> On Wed, Jun 8, 2011 at 9:47 AM, Ashish Sharma <ashishs99 at gmail.com>
>>>wrote:
>>>>
>>>> I am facing this problem while committing my local changes: I keep
>>>>getting
>>>> the familiar error:
>>>>
>>>> Your work tree has not been configured for ITK development.
>>>>
>>>> Paste the following commands into a shell:
>>>>
>>>>  ./Utilities/SetupForDevelopment.sh
>>>>
>>>> See http://www.itk.org/Wiki/ITK/Git/Develop for more details.
>>>> I have tried removing the Hooks and running the setup again but of no
>>>>avail.
>>>> Could anyone suggest what might be wrong here?
>>>>
>>>> Thanks,
>>>> Ashish
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>
>>>>
>>>
>>_______________________________________________
>>Powered by www.kitware.com
>>
>>Visit other Kitware open-source projects at
>>http://www.kitware.com/opensource/opensource.html
>>
>>Kitware offers ITK Training Courses, for more information visit:
>>http://kitware.com/products/protraining.html
>>
>>Please keep messages on-topic and check the ITK FAQ at:
>>http://www.itk.org/Wiki/ITK_FAQ
>>
>>Follow this link to subscribe/unsubscribe:
>>http://www.itk.org/mailman/listinfo/insight-developers
>
>
>
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> ________________________________
>