[Insight-developers] Languishing Gerrit Top For SystemPNG

[Williams, Norman K]

See: http://review.source.kitware.com/#change,1758


This patch does two things:

1. There's a typo in Modules/ThirdParty/PNG/CMakeLists.txt that means
USE_SYSTEM_PNG was 100% broken -- PNG_INCLUDE_DIRS is used instead of
PNG_INCLUDE_DIR, which is what the PNG CMake module defines.

2. ITK's version is quite old -- there's an API change that needs to be
   accomodated, and in the latest revision, PNG makes its data structures
   private, and access to structure members goes through access functions.

I did this work a week ago and Bill Lorensen was the only person to review
the patch. He pointed out that there's no test added for the patch, but I
don't know how you'd write a test for USE_SYSTEM_<LIB>.

I would like to merge this patch. Can someone else have a look?

The other alternative is to remove USE_SYSTEM_PNG as an option, and always
use the ITK-internal version.



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________