[Insight-developers] Change in ITK[master]: COMP: fix warnings about hidden method SetNumberOfThreads

[Gelas, Arnaud Joel Florent]

Bill

Thanks for taking care of it! It is indeed an excellent lesson!!!

---

I just wanted to point that at least these warnings could have been caught when patches were submitted on gerrit if gerrit robot (mac and linux machines) were using more conservative flags.
Would it be possible to use the most conservative set of gcc flags for robots?

For instance, here are the flags used for bonito.megason-lab.hms (FC 13)

CMAKE_CXX_FLAGS:STRING=-Wno-deprecated -Wall -Wextra -Wformat=2 -Wno-format-nonliteral -Wunused -Wpointer-arith -Winvalid-pch -Wcast-align -Wdisabled-optimization -Woverloaded-virtual -Wshadow -Wwrite-strings -Wstrict-null-sentinel

CMAKE_C_FLAGS:STRING=-Wall -Wextra -Wformat=2 -Wno-format-nonliteral -Wunused -Wpointer-arith -Winvalid-pch -Wcast-align -Wdisabled-optimization -Wshadow -Wwrite-strings

Thanks,
Arnaud
________________________________________
From: Bill Lorensen [bill.lorensen at gmail.com]
Sent: Saturday, June 11, 2011 4:29 PM
To: Insight Developers
Cc: Gelas, Arnaud Joel Florent; Cory Quammen; David Doria; Luis Ibanez
Subject: Re: Change in ITK[master]: COMP: fix warnings about hidden method SetNumberOfThreads

FYI: I just posted a patch with another 40 files that need changing:
http://review.source.kitware.com/#change,1857
As the commit message says:
"This and related topics illustrate a lesson to be learned: Nothing is
simple nor inexpensive."

Bill

On Sat, Jun 11, 2011 at 1:45 PM, Code Review <review at kitware.com> wrote:
> From Kitware Robot <kwrobot at kitware.com>:
>
> Kitware Robot has submitted this change and it was merged.
>
> Change subject: COMP: fix warnings about hidden method SetNumberOfThreads
> ......................................................................
>
>
> COMP: fix warnings about hidden method SetNumberOfThreads
>
> Change-Id: I937e2a0805ca9ba46790c62bf713cd207ab76f76
> ---
> M Modules/Filtering/ImageGradient/include/itkGradientMagnitudeRecursiveGaussianImageFilter.h
> M Modules/Filtering/ImageGradient/include/itkGradientMagnitudeRecursiveGaussianImageFilter.txx
> M Modules/Filtering/MathematicalMorphology/include/itkGrayscaleDilateImageFilter.h
> M Modules/Filtering/MathematicalMorphology/include/itkGrayscaleDilateImageFilter.txx
> M Modules/Filtering/MathematicalMorphology/include/itkGrayscaleErodeImageFilter.h
> M Modules/Filtering/MathematicalMorphology/include/itkGrayscaleErodeImageFilter.txx
> M Modules/Filtering/Smoothing/include/itkSmoothingRecursiveGaussianImageFilter.h
> M Modules/Filtering/Smoothing/include/itkSmoothingRecursiveGaussianImageFilter.txx
> M Modules/Nonunit/Deprecated/include/itkNonThreadedShrinkImageFilter.h
> M Modules/Nonunit/Review/include/itkMiniPipelineSeparableImageFilter.h
> M Modules/Nonunit/Review/include/itkMiniPipelineSeparableImageFilter.txx
> 11 files changed, 11 insertions(+), 11 deletions(-)
>
> Approvals:
>  David Doria: Looks good to me, but someone else must approve
>  Bill Lorensen: Looks good to me, approved
>
>
> --
> To view, visit http://review.source.kitware.com/1854
> To unsubscribe, visit http://review.source.kitware.com/settings
>
> Gerrit-MessageType: merged
> Gerrit-Change-Id: I937e2a0805ca9ba46790c62bf713cd207ab76f76
> Gerrit-PatchSet: 1
> Gerrit-Project: ITK
> Gerrit-Branch: master
> Gerrit-Owner: Arnaud Gelas <arnaud_gelas at hms.harvard.edu>
> Gerrit-Reviewer: Arnaud Gelas <arnaud_gelas at hms.harvard.edu>
> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
> Gerrit-Reviewer: Cory Quammen <cquammen at cs.unc.edu>
> Gerrit-Reviewer: David Doria <daviddoria at gmail.com>
>