[Insight-developers] Fwd: [ITK 0010633]: itk::NonUniformBSpline can not be instantiated
Johnson, Hans J
hans-johnson at uiowa.edu
Fri Jun 17 12:53:38 EDT 2011
Yes! This bug is now closed!
Thanks,
Hans
From: Nicholas Tustison <ntustison at gmail.com<mailto:ntustison at gmail.com>>
Date: Fri, 17 Jun 2011 12:46:44 -0400
To: ITK <insight-developers at itk.org<mailto:insight-developers at itk.org>>
Subject: [Insight-developers] Fwd: [ITK 0010633]: itk::NonUniformBSpline can not be instantiated
Quick question regarding the recent bug assignment---if something is
labeled as ITK-deprecated, doesn't that mean it's slated for removal?
Thanks,
Nick
Begin forwarded message:
From: Mantis Bug Tracker <mantis at public.kitware.com<mailto:mantis at public.kitware.com>>
Date: June 17, 2011 12:31:42 PM EDT
To: ntustison at wustl.edu<mailto:ntustison at wustl.edu>
Subject: [ITK 0010633]: itk::NonUniformBSpline can not be instantiated
The following issue has been ASSIGNED.
======================================================================
http://public.kitware.com/Bug/view.php?id=10633
======================================================================
Reported By: jneuhaus
Assigned To: Nick Tustison
======================================================================
Project: ITK
Issue ID: 10633
Category:
Reproducibility: always
Severity: major
Priority: normal
Status: assigned
Resolution Date:
Sprint:
Sprint Status:
======================================================================
Date Submitted: 2010-04-28 09:42 EDT
Last Modified: 2011-06-17 12:31 EDT
======================================================================
Summary: itk::NonUniformBSpline can not be instantiated
Description:
I try to compile a very simple test program (see section "Steps To Reproduce")
that basically defines a variable of type itk::NonUniformBSpline<3>.
Visual Studio 2008 produces the following complier error:
Compiling...
mitkSplineTest.cpp
v:\windows\source\itk318\code\common\itkNonUniformBSpline.h(83) : error C2679:
binary '<<' : no operator found which takes a right-hand operand of type 'const
std::vector<_Ty>' (or there is no acceptable conversion)
with
[
_Ty=itk::Point<itk::NonUniformBSpline<3>::ScalarType,3>
]
[... <-- lot of output with possible types that do not match...]
The same code was working on ITK 3.16.
I suppose, the problem is, that this class is not used anywhere in ITK and that
there is no unit test for the class, therefore changes to the class were never
really compiled (e.g. bug http://public.kitware.com/Bug/view.php?id=10458).
Steps to Reproduce:
#include <itkNonUniformBSpline.h>
int main(int /* argc */, char* /*argv*/[])
{
typedef itk::NonUniformBSpline<3> SplineType;
SplineType::Pointer mySpline;
return 0;
}
======================================================================
----------------------------------------------------------------------
(0020461) jneuhaus (reporter) - 2010-04-28 10:13
http://public.kitware.com/Bug/view.php?id=10633#c20461
----------------------------------------------------------------------
An important note: This compiler error only occurs in DEBUG mode!
Digging deeper, I found that the problem is the use of the
itkGetConstReferenceMacro() to return the non-ITK type PointListType which is a
stl container:
typedef std::vector < PointType > PointListType;
the macro tries to pipe the vector into an output stream, which fails because
there is no operator to pipe stl vectors:
itkDebugMacro("returning " << #name " of " << this->m_##name ); \
(this syntax is strange, I would expect either << before AND after #name or not
at all, but this is not part of this bug report)
----------------------------------------------------------------------
(0020462) jneuhaus (reporter) - 2010-04-28 11:48
http://public.kitware.com/Bug/view.php?id=10633#c20462
----------------------------------------------------------------------
I also posted this to the mailing list and got a reply from Luis Ibanez:
http://www.itk.org/pipermail/insight-users/2010-April/036546.html
----------------------------------------------------------------------
(0020464) Luis Ibanez (manager) - 2010-04-28 12:52
http://public.kitware.com/Bug/view.php?id=10633#c20464
----------------------------------------------------------------------
The patch has been committed to the CVS Head.
In includes a unit test for the NonUniformBSpline class.
The test still needs some work on verifying the correctness of its numerical
outputs.
http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Common/itkNonUniformBSpline.h?root=Insight&r1=1.6&r2=1.7&sortby=date
http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Common/itkNonUniformBSpline.txx?root=Insight&r1=1.8&r2=1.9&sortby=date
http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Common/itkCommonTests2.cxx?root=Insight&r1=1.30&r2=1.31&sortby=date
http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Common/CMakeLists.txt?root=Insight&r1=1.253&r2=1.254&sortby=date
New File
http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Common/itkNonUniformBSplineTest.cxx?root=Insight&sortby=date&view=log
We will wait to see tomorrow's Dashboard.
If it is green we will commit the same patch to the ITK 3.18 branch.
----------------------------------------------------------------------
(0022994) Luis Ibanez (manager) - 2010-11-07 02:00
http://public.kitware.com/Bug/view.php?id=10633#c22994
----------------------------------------------------------------------
The class does compile now,
but its implementation is not completed.
This class should be removed from ITK,
or at least, be moved to a module in the periphery.
Issue History
Date Modified Username Field Change
======================================================================
2010-04-28 09:42 jneuhaus New Issue
2010-04-28 10:13 jneuhaus Note Added: 0020461
2010-04-28 11:48 jneuhaus Note Added: 0020462
2010-04-28 12:26 Luis Ibanez Status new => assigned
2010-04-28 12:26 Luis Ibanez Assigned To => Luis Ibanez
2010-04-28 12:47 Luis Ibanez File Added: NonUniformBSpline.patch
2010-04-28 12:47 Luis Ibanez File Added: itkNonUniformBSplineTest.cxx
2010-04-28 12:52 Luis Ibanez Note Added: 0020464
2010-11-07 02:00 Luis Ibanez Note Added: 0022994
2011-06-17 12:31 Hans Johnson Assigned To Luis Ibanez => Nick
Tustison
======================================================================
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.html Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110617/07dd68b4/attachment.htm>
More information about the Insight-developers
mailing list