[Insight-developers] removing the dash in the module names

Gaëtan Lehmann gaetan.lehmann at jouy.inra.fr
Thu Jun 23 10:15:44 EDT 2011


Le 23 juin 11 à 15:19, Bill Lorensen a écrit :

> Virtually every .h file in the toolkit will need editing... Is there
> some other, perhaps wrapping-specific solution?

That would force us to do a lot of conversions with cmake.
In addition to make the code more complicated, I'm concerned that it  
may make the already quite slow configuration even slower.

Is it really a big problem to touch all the headers?

Gaëtan



>
> On Thu, Jun 23, 2011 at 8:53 AM, Brad King <brad.king at kitware.com>  
> wrote:
>> On 06/23/2011 04:07 AM, Gaëtan Lehmann wrote:
>>> most of the languages won't support a dash in the module name.
>>>
>>> Would it be ok to remove those dash in the module names?
>>>
>>>    ITK-Common
>>>    ITK-IO-Base
>>>
>>> would become
>>>
>>>    ITKCommon
>>>    ITKIOBase
>>
>> Perhaps underscores?
>>
>>  ITK_Common
>>  ITK_IO_Base
>>
>> IMO having a separator breaks with our C++ coding guideline naming
>> style enough to clearly distinguish the names as modules.  It also
>> makes the name components clear, especially when the module names
>> are all uppercase.  Consider
>>
>>  ITK-IO-PNG   =>  ITKIOPNG  v. ITK_IO_PNG
>>  ITK-IO-TIFF  =>  ITKIOTIFF v. ITK_IO_TIFF
>>
>> -Brad
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://mima2.jouy.inra.fr  http://www.itk.org
http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110623/8fa55d04/attachment.pgp>


More information about the Insight-developers mailing list