[Insight-developers] removing the dash in the module names

[David Cole]

Why couldn't there be a name-mapping (reversible, 2-way) in just the
Wrapping libraries? Are the "real" module names referenced directly in many
places other than target_link_libraries calls?

How many languages can't handle the "-" in names? Is it just python, or are
dashes also bad in some other language?


On Thu, Jun 23, 2011 at 11:15 AM, Xiaoxiao Liu <xiaoxiao.liu at kitware.com>wrote:

> Yup, not only most of the cmake files need some string replacements, all
> the header files (for doxygen) need to be touched as well.
> It might affect all other under-development external modules (e.g. Lesion
> sizing toolkit, maybe a couple of other out there).
>
> If there is no easy work-around, I prefer Bra'd's  "underscore" naming.
>
>
>
> 2011/6/23 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>
>
>>
>> Le 23 juin 11 à 15:19, Bill Lorensen a écrit :
>>
>>
>>  Virtually every .h file in the toolkit will need editing... Is there
>>> some other, perhaps wrapping-specific solution?
>>>
>>
>> That would force us to do a lot of conversions with cmake.
>> In addition to make the code more complicated, I'm concerned that it may
>> make the already quite slow configuration even slower.
>>
>> Is it really a big problem to touch all the headers?
>>
>> Gaëtan
>>
>>
>>
>>
>>
>>> On Thu, Jun 23, 2011 at 8:53 AM, Brad King <brad.king at kitware.com>
>>> wrote:
>>>
>>>> On 06/23/2011 04:07 AM, Gaëtan Lehmann wrote:
>>>>
>>>>> most of the languages won't support a dash in the module name.
>>>>>
>>>>> Would it be ok to remove those dash in the module names?
>>>>>
>>>>>   ITK-Common
>>>>>   ITK-IO-Base
>>>>>
>>>>> would become
>>>>>
>>>>>   ITKCommon
>>>>>   ITKIOBase
>>>>>
>>>>
>>>> Perhaps underscores?
>>>>
>>>>  ITK_Common
>>>>  ITK_IO_Base
>>>>
>>>> IMO having a separator breaks with our C++ coding guideline naming
>>>> style enough to clearly distinguish the names as modules.  It also
>>>> makes the name components clear, especially when the module names
>>>> are all uppercase.  Consider
>>>>
>>>>  ITK-IO-PNG   =>  ITKIOPNG  v. ITK_IO_PNG
>>>>  ITK-IO-TIFF  =>  ITKIOTIFF v. ITK_IO_TIFF
>>>>
>>>> -Brad
>>>> ______________________________**_________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/**opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/**protraining.html<http://kitware.com/products/protraining.html>
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_**FAQ <http://www.itk.org/Wiki/ITK_FAQ>
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/**listinfo/insight-developers<http://www.itk.org/mailman/listinfo/insight-developers>
>>>>
>>>>
>> --
>> Gaëtan Lehmann
>> Biologie du Développement et de la Reproduction
>> INRA de Jouy-en-Josas (France)
>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> http://mima2.jouy.inra.fr  http://www.itk.org
>> http://www.bepo.fr
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>
>
> --
>
>
> ---------------------------------------------
> *Xiaoxiao Liu*, Ph.D.
> R & D Engineer
> Kitware Inc <http://www.kitware.com/>.
> Clifton Park, NY
> Phone: (518) 881-4924  or  (518) 371-3971 x124
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110623/43cbf7f7/attachment.htm>