[Insight-developers] My Current Gerrit topics hanging fire...

[Bill Lorensen]

David,

I think you are correct. However, I will add the caveat, that unless
you are a diligent weekend worker, do not merge on a Friday (or before
a big meeting next week).

Bill

On Fri, Jun 24, 2011 at 4:52 PM, David Cole <david.cole at kitware.com> wrote:
> I thought the rule of thumb was that if you have successful cdash at home
> builds for the topic, and nobody objects to it within a reasonable
> time frame (say, 24 to 48 hours after the last update to the gerrit
> entry) then it was a-ok to merge, full speed ahead.
>
> If nobody objects, you are free to merge, but still responsible for
> the changes, and responsible to follow up if they cause problems.
>
> Although, if there is potential for interactions among the topics,
> doing them one per day and observing the nightly dashboards in between
> might be a good idea.
>
> Is my understanding correct? Or is there some other guidance on this
> subject that I'm not aware of?
>
>
> HTH,
> David
>
>
>
> On Fri, Jun 24, 2011 at 4:35 PM, Williams, Norman K
> <norman-k-williams at uiowa.edu> wrote:
>> Evaluators say the patches look good, but no one wants to approve! Truly,
>> there are no logic bombs contained therein!
>>
>> http://review.source.kitware.com/#change,1930
>>
>> http://review.source.kitware.com/#change,1939
>> http://review.source.kitware.com/#change,1958
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
>> ________________________________
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>