[Insight-developers] Gerrit factory build links to incorrect cdash builds

[Marcus D. Hanwell]

Yes, it looks like the JSON that Gerrit spits out retained the
original name. I will look into that tomorrow, after some discussion I
think I can fix up the filter to be a little more robust without too
much work (using 7 characters from the commit sha in the build
name/filter).

Marcus

On Thu, Jun 30, 2011 at 10:24 AM, David Cole <david.cole at kitware.com> wrote:
> CDash at home builds with whatever build name gerrit tells it to. So I'm
> thinking there's a topic name glitch in the gerrit event listener that
> dispatches the CDash at home builds...
>
>
> On Thu, Jun 30, 2011 at 10:02 AM, Bradley Lowekamp <blowekamp at mail.nih.gov>
> wrote:
>>
>> Hello,
>> Yes, David I was guilty of having my topic named master in PS 1 ( maybe
>> two too ) but I did correct it by PS 3. However the CDash at Home did not seem
>> to pickup on this. So the potential bug with the CD at H scripts is that it
>> does not detect a change in the topic name.
>> Brad
>> On Jun 30, 2011, at 9:53 AM, David Cole wrote:
>>
>> On Thu, Jun 30, 2011 at 9:48 AM, Marcus D. Hanwell
>> <marcus.hanwell at kitware.com> wrote:
>>>
>>> On Wed, Jun 29, 2011 at 6:13 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>> wrote:
>>> > Folks,
>>> >
>>> > This gerrit topic:
>>> > http://review.source.kitware.com/#change,1998
>>> >
>>> > points to this build:
>>> >
>>> > http://www.cdash.org/CDash/index.php?project=Insight&filtercount=2&field1=buildname/string&compare1=63&value1=master&field2=buildstarttime/date&compare2=83&value2=2011-6-29
>>> >
>>> > It is not the correct build. Perhaps the gerrit generated cdash filter
>>> >  is incorrect?
>>> >
>>> I will take a look, it also looks like the build names generated were
>>> incorrect.
>>>
>>> Marcus
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>> This is because the topic name is "master" -- you have to name your topic
>> branch something unique in order for this CDash filter page to show up
>> correctly.
>>
>> Name your topic branches descriptively, please. Do not commit directly on
>> master, ever.
>>
>>
>> David C.
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>
>