[Insight-developers] InPlace filters crashing after checkin

[Bradley Lowekamp]

Very, nice! I am glad I was on the right track, but was significantly behind.

I have perviously made a simular change to ImageSource::GetOutput(). The resulting change was rather un-expected to certain users so a warning message was added to the method:


/**
 *
 */
template< class TOutputImage >
typename ImageSource< TOutputImage >::OutputImageType *
ImageSource< TOutputImage >
::GetOutput(unsigned int idx)
{
  TOutputImage *out = dynamic_cast< TOutputImage * >
                      ( this->ProcessObject::GetOutput(idx) );

  if ( out == NULL )
    {
    itkWarningMacro (<< "dynamic_cast to output type failed");
    }
  return out;
}

Brad


On Nov 3, 2011, at 10:58 AM, Gaëtan Lehmann wrote:

> 
> Sorry, forgot to post the link.
> A proposed fix here:
> 
>  http://review.source.kitware.com/#change,3190
> 
> 
> Le 3 nov. 11 à 15:54, Bradley Lowekamp a écrit :
> 
>> OK,
>> 
>> I am on the right track for this now...
>> 
>> Figuring out the two similar tests helped:
>> 
>> diff Modules/Nonunit/Review/test/itkMultiplyByConstantImageFilterTest.cxx Modules/Compatibility/Deprecated/test/itkMultiplyByConstantImageFilterTest.cxx
>> 
>> 18d17
>> <
>> 20c19
>> < #include "itkMultiplyImageFilter.h"
>> ---
>> > #include "itkMultiplyByConstantImageFilter.h"
>> 91,92c90,91
>> <   typedef itk::MultiplyImageFilter<
>> <     InputImageType, InputImageType, OutputImageType  >   FilterType;
>> ---
>> >   typedef itk::MultiplyByConstantImageFilter<
>> >     InputImageType, FactorType, OutputImageType  >   FilterType;
>> 100c99
>> <   filter->SetInput2( inputImage );
>> ---
>> >   filter->SetInput( inputImage );
>> 107c106
>> <   filter->SetInput1( factor );
>> ---
>> >   filter->SetConstant( factor );
>> 
>> Input1 may not be a image in the failing cases.
>> 
>> 
>> WIP...
>> 
>> Brad
>> 
>> 
>> On Nov 3, 2011, at 8:42 AM, Bill Lorensen wrote:
>> 
>>> Gaëtan,
>>> 
>>> Various inplace filters are crashing intermittently after your checkin last night. The placement of your new logic should probably be put inside the existing if test. I guess you and the reviewers missed the failing robot tests of your gerrit topic.
>>> 
>>> Bill
>>> 
>>> -- 
>>> Unpaid intern in BillsBasement at noware dot com
>>> 
>>> _______________________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>> 
>> ========================================================
>> Bradley Lowekamp
>> Medical Science and Computing for
>> Office of High Performance Computing and Communications
>> National Library of Medicine
>> blowekamp at mail.nih.gov
>> 
>> 
>> 
> 
> -- 
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://mima2.jouy.inra.fr  http://www.itk.org
> http://www.bepo.fr
> 

========================================================
Bradley Lowekamp  
Medical Science and Computing for
Office of High Performance Computing and Communications
National Library of Medicine 
blowekamp at mail.nih.gov



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20111103/231d06d0/attachment-0001.htm>