[Insight-developers] Rigid3DTransform API has const-correctness oversight?

Williams, Norman K norman-k-williams at uiowa.edu
Tue Sep 6 15:33:56 EDT 2011


There's a method in this class

const MatrixType& GetRotationMatrix();

That I think needs to be

const MatrixType& GetRotationMatrix() const;

It being non const is even more absurd when you peek at the
implementation: It just calls
MatrixOffsetTransformBase::GetMatrix() -- which is a const function
returning a const reference.

This causes a problem I ran into that ought to have showed up before now:
if you call GetRotationMatrix via a const * or
Rigid3DTransform::ConstPointer you get an error saying you're throwing
away const-ness.

Will changing this be an API change, or just the correction of an
oversight?

-- Kent Williams norman-k-williams at uiowa.edu






________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________


More information about the Insight-developers mailing list